Each spatial tile decoded by MiniMaxH3VideoVAE.tiled_decode was
normalized to its own local -1..1 rotary position range instead of its
true offset within the full latent grid, since tiling defaults to on
(tile_size=256) at any resolution above that. The ViT3D decoder then
saw every tile as if it were the whole frame, so adjacent tiles came
out with different learned appearance and visible seams (#15548).
create_token_ids now takes the full latent grid size and the tile's
offset within it, and tiled_decode passes them through so tile
position ids match a single-shot decode of the whole frame.
Add a ModelAttentionBackend node to manually select the attention for models in the workflows. Currently supports pytorch attention or comfy kitchen attention.
Add --use-ck-attention to enable comfy kitchen attention as the default attention backend for all models (might break some).
This avoids name collision (circular imports) for external custom nodes,
for which the comfy path is pushed into sys.path so Python's own logging module
is shadowed otherwise.
fixes: #15229
This priority scheme was broken in the case where you have pin
registration exhaustion while loading a VBAR that gets a big evicition.
The weight would stay in the loaded set but inherit the MRU priority
against other workflow models WRT pin registration which leads to async
offload without pinning.
Fix by universally promiting active pin registration above workflow
pins without concern for the weights/weights-loaded split. This diverges
from the actual budgeting where the split still makes sense.
Changes:
Remove sequential scan hint
Prefer NVML pressure on windows
Add async malloc clamp option (unused by comfy so far)
Workaround AMD windows GPU virtual address space leak
The largest change is the NVML pressure, which works around a cuMemGetInfo
drift from actual VRAM in some circumstances.
Windows has proven this logic works for a long time and there are
corner cases where this materialization actual consumes real RAM
on linux.
Its not as bad as the original windows commit charge surge, but
its still a detectable transient leak. So simplify and unify.
chelsealong
Jukka Seppänen
Barish Ozbay
comfyanonymous
rattus
Alexander Brown
Alex Harper
Alexis Rolland
blepping
endman100
rivadart
Oliver Freyermuth