From c79d17c8ffb8fbdf19ad2b361723a25235470a21 Mon Sep 17 00:00:00 2001 From: CarterPerez-dev Date: Sat, 11 Apr 2026 07:27:25 -0400 Subject: [PATCH] fix: remove unused imports and merge comparison in dlp-scanner Remove unused TextChunk, DetectorMatch, make_flow_key imports and merge repeated DNS_PORT equality check into set membership test. --- .../src/dlp_scanner/scanners/file_scanner.py | 5 +---- .../src/dlp_scanner/scanners/network_scanner.py | 12 +++++------- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/file_scanner.py b/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/file_scanner.py index b83ac5a1..2046cbc6 100644 --- a/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/file_scanner.py +++ b/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/file_scanner.py @@ -35,10 +35,7 @@ from dlp_scanner.extractors.structured import ( XmlExtractor, YamlExtractor, ) -from dlp_scanner.models import ( - ScanResult, - TextChunk, -) +from dlp_scanner.models import ScanResult from dlp_scanner.scoring import match_to_finding diff --git a/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/network_scanner.py b/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/network_scanner.py index 2ebc54a6..936b9212 100644 --- a/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/network_scanner.py +++ b/PROJECTS/intermediate/dlp-scanner/src/dlp_scanner/scanners/network_scanner.py @@ -10,7 +10,6 @@ from pathlib import Path import structlog from dlp_scanner.config import ScanConfig -from dlp_scanner.detectors.base import DetectorMatch from dlp_scanner.detectors.registry import DetectorRegistry from dlp_scanner.models import ( Finding, @@ -22,10 +21,7 @@ from dlp_scanner.network.exfiltration import ( ExfilIndicator, detect_base64_payload, ) -from dlp_scanner.network.flow_tracker import ( - FlowTracker, - make_flow_key, -) +from dlp_scanner.network.flow_tracker import FlowTracker from dlp_scanner.network.pcap import read_pcap from dlp_scanner.network.protocols import ( DNS_PORT, @@ -131,8 +127,10 @@ class NetworkScanner: if ( packet.protocol == "udp" and ( - packet.src_port == DNS_PORT - or packet.dst_port == DNS_PORT + DNS_PORT in ( + packet.src_port, + packet.dst_port, + ) ) ): self._process_dns_packet(