RomanNum3ral
/
OpenCut
mirror of https://github.com/OpenCut-app/OpenCut.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: ensure clicking context menu item doesn't move timeline playhead

This commit is contained in:
Maze Winther 2025-07-26 12:34:57 +02:00
parent 317ee9141e
commit 043bf7d70a
2 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/web/src/components/editor/timeline/index.tsx
View File

@ -746,11 +746,14 @@ export function Timeline() {
</ContextMenuTrigger>
<ContextMenuContent className="z-[200]">
<ContextMenuItem
onClick={() => toggleTrackMute(track.id)}
onClick={(e) => {
e.stopPropagation();
toggleTrackMute(track.id);
}}
>
{track.muted ? "Unmute Track" : "Mute Track"}
</ContextMenuItem>
<ContextMenuItem>
<ContextMenuItem onClick={(e) => e.stopPropagation()}>
Track settings (soon)
</ContextMenuItem>
</ContextMenuContent>

12
apps/web/src/components/editor/timeline/timeline-element.tsx
View File

@ -102,7 +102,8 @@ export function TimelineElement({
// Element should always be positioned at startTime - trimStart only affects content, not position
const elementLeft = elementStartTime * 50 * zoomLevel;
const handleElementSplitContext = () => {
const handleElementSplitContext = (e: React.MouseEvent) => {
e.stopPropagation();
const effectiveStart = element.startTime;
const effectiveEnd =
element.startTime +
@ -118,7 +119,8 @@ export function TimelineElement({
}
};
const handleElementDuplicateContext = () => {
const handleElementDuplicateContext = (e: React.MouseEvent) => {
e.stopPropagation();
const { id, ...elementWithoutId } = element;
addElementToTrack(track.id, {
...elementWithoutId,
@ -130,7 +132,8 @@ export function TimelineElement({
});
};
const handleElementDeleteContext = () => {
const handleElementDeleteContext = (e: React.MouseEvent) => {
e.stopPropagation();
if (rippleEditingEnabled) {
removeElementFromTrackWithRipple(track.id, element.id);
} else {
@ -138,7 +141,8 @@ export function TimelineElement({
}
};
const handleReplaceClip = () => {
const handleReplaceClip = (e: React.MouseEvent) => {
e.stopPropagation();
if (element.type !== "media") {
toast.error("Replace is only available for media clips");
return;