RomanNum3ral
/
OpenCut
mirror of https://github.com/OpenCut-app/OpenCut.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: move ACTIONS_WITH_REQUIRED_ARGS to module scope 

Per CodeRabbit review: avoid recreating the Set on every function call
by declaring it as a module-level constant, consistent with the pattern
used for MODIFIER_KEYS_SET and ACTION_KEYS_SET.
This commit is contained in:
hevink 2026-05-16 13:19:49 +05:30
parent 25549b8be2
commit 589e8f68a1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
apps/web/src/actions/types.ts
View File

@ -27,6 +27,11 @@ export type TActionWithNoArgs = Exclude<TAction, TActionWithArgs>;
const ACTION_KEYS_SET: ReadonlySet<string> = new Set(Object.keys(ACTIONS));
const ACTIONS_WITH_REQUIRED_ARGS: ReadonlySet<string> = new Set([
"remove-media-asset",
"remove-media-assets",
]);
export function isAction(value: string): value is TAction {
return ACTION_KEYS_SET.has(value);
}
@ -34,10 +39,6 @@ export function isAction(value: string): value is TAction {
export function isActionWithOptionalArgs(value: string): value is TActionWithOptionalArgs {
if (!isAction(value)) return false;
// Actions that require mandatory (non-undefined) args cannot be used as keybindings
const ACTIONS_WITH_REQUIRED_ARGS: ReadonlySet<string> = new Set([
"remove-media-asset",
"remove-media-assets",
]);
return !ACTIONS_WITH_REQUIRED_ARGS.has(value);
}