From 726d9cb90bab4066e196b5a0e01fd17c27018eec Mon Sep 17 00:00:00 2001
From: naoNao89 <90588855+naoNao89@users.noreply.github.com>
Date: Wed, 30 Jul 2025 00:27:08 +0700
Subject: [PATCH] feat: add MOV format support and fix cleanup in VideoExporter

- Add codec configuration for MOV format in buildFFmpegCommand
- Use libx264 video codec and aac audio codec for MOV exports
- Fix cleanup method to properly remove progress event listeners
- Store progressCallback reference to enable proper event listener removal
- Prevent memory leaks by correctly cleaning up FFmpeg event handlers
---
 apps/web/src/lib/export-utils.ts | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/apps/web/src/lib/export-utils.ts b/apps/web/src/lib/export-utils.ts
index 1fc0505b..8fae2bfb 100644
--- a/apps/web/src/lib/export-utils.ts
+++ b/apps/web/src/lib/export-utils.ts
@@ -20,6 +20,7 @@ export type ExportProgress = {
 export class VideoExporter {
   private ffmpeg: FFmpeg | null = null;
   private onProgress?: (progress: ExportProgress) => void;
+  private progressCallback?: (data: { progress: number }) => void;
 
   constructor(onProgress?: (progress: ExportProgress) => void) {
     this.onProgress = onProgress;
@@ -46,9 +47,10 @@ export class VideoExporter {
     this.ffmpeg = await initFFmpeg();
 
     // Set up progress callback for FFmpeg
-    this.ffmpeg.on("progress", ({ progress }) => {
+    this.progressCallback = ({ progress }) => {
       this.updateProgress("processing", progress * 100, "Rendering video...");
-    });
+    };
+    this.ffmpeg.on("progress", this.progressCallback);
 
     try {
       this.updateProgress("preparing", 10, "Analyzing timeline...");
@@ -243,6 +245,8 @@ export class VideoExporter {
       args.push("-c:v", "libx264", "-c:a", "aac");
     } else if (options.format === "webm") {
       args.push("-c:v", "libvpx-vp9", "-c:a", "libopus");
+    } else if (options.format === "mov") {
+      args.push("-c:v", "libx264", "-c:a", "aac");
     }
 
     args.push(outputName);
@@ -270,9 +274,9 @@ export class VideoExporter {
   }
 
   cleanup() {
-    if (this.ffmpeg) {
+    if (this.ffmpeg && this.progressCallback) {
       // Remove all progress listeners
-      this.ffmpeg.off("progress", () => {});
+      this.ffmpeg.off("progress", this.progressCallback);
     }
   }
 }