RomanNum3ral
/
Solaar
mirror of https://github.com/pwr-Solaar/Solaar.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ui: Use GtkButton for the Lock Icon 

Instead of GtkEventBox use GtkButton for the lock icons.

GtkEventBox does not have any visual feedback that it
actually can be pressed. As in: If you don't know that this
is an area for interaction it is not obvious.

Using Gtk.ReliefStyle.NONE on the GtkButton keeps the old
styling but still gives feedback when hovering over the
buttons.

Co-authored-by: Christian Tacke <8560110+ChristianTacke@users.noreply.github.com>
This commit is contained in:
Christian Tacke 2021-12-28 18:27:03 +01:00 committed by GitHub
parent 79606c530b
commit 49e9240be9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/solaar/ui/config_panel.py
View File

@ -361,9 +361,9 @@ _icons_allowables = {v: k for k, v in _allowables_icons.items()}
# clicking on the lock icon changes from changeable to unchangeable to ignore # clicking on the lock icon changes from changeable to unchangeable to ignore
def _change_click(eb, button, arg): def _change_click(button, arg):
control, sbox, device, name = arg control, sbox, device, name = arg
icon = eb.get_children()[0] icon = button.get_children()[0]
icon_name, _ = icon.get_icon_name() icon_name, _ = icon.get_icon_name()
allowed = _icons_allowables.get(icon_name, True) allowed = _icons_allowables.get(icon_name, True)
new_allowed = _next_allowable[allowed] new_allowed = _next_allowable[allowed]
@ -402,7 +402,8 @@ def _create_sbox(s, device):
change_icon = Gtk.Image.new_from_icon_name('changes-prevent', Gtk.IconSize.LARGE_TOOLBAR) change_icon = Gtk.Image.new_from_icon_name('changes-prevent', Gtk.IconSize.LARGE_TOOLBAR)
_change_icon(False, change_icon) _change_icon(False, change_icon)
change = Gtk.EventBox() change = Gtk.Button()
change.set_relief(Gtk.ReliefStyle.NONE)
change.add(change_icon) change.add(change_icon)
if s.kind == _SETTING_KIND.toggle: if s.kind == _SETTING_KIND.toggle:
@ -429,7 +430,7 @@ def _create_sbox(s, device):
control.kind = s.kind control.kind = s.kind
change.set_sensitive(True) change.set_sensitive(True)
change.connect('button-press-event', _change_click, (control, sbox, device, s.name)) change.connect('clicked', _change_click, (control, sbox, device, s.name))
if s.kind in [_SETTING_KIND.multiple_toggle, _SETTING_KIND.multiple_range]: if s.kind in [_SETTING_KIND.multiple_toggle, _SETTING_KIND.multiple_range]:
vbox._header.pack_start(label, False, False, 0) vbox._header.pack_start(label, False, False, 0)