RomanNum3ral
/
Solaar
mirror of https://github.com/pwr-Solaar/Solaar.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

settings: for polling rate setting only change profiles mode when actually writing

This commit is contained in:
Peter F. Patel-Schneider 2021-04-10 10:22:50 -04:00
parent 33a4bf8bf5
commit 5be7541875
2 changed files with 28 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
docs/index.md
View File

@ -113,16 +113,20 @@ for the step-by-step procedure for manual installation.
## Known Issues
- If some icons appear broken in the application, make sure you've properly
configured the Gtk theme and icon theme in your control panel.
- There are several implementations of the system tray. Some of these have problems
that can result in missing or wrong-sized icons.
- The icon in the system tray can show up as 'black on black' in dark
distributions. This is due to problems in many system tray
implementations. Changing to a different theme may help.
themes or as non-symbolic when the theme uses symbolic icons. This is due to problems
in some system tray implementations. Changing to a different theme may help.
The `--battery-icons=symbolic` option can be used to force symbolic icons.
- Sometimes the system tray icon does not show up. The cause of this is unknown.
Either wait a while and try again or try with the `--window=hide` option.
- If some icons appear broken in the application, make sure you've properly
configured the Gtk theme and icon theme in your control panel.
- Running the command-line application while the GUI
application is also running *may* occasionally cause either of them to become
confused about the state of the devices.
@ -131,10 +135,17 @@ for the step-by-step procedure for manual installation.
implement smooth scrolling. If Solaar changes this setting after the driver is
set up scrolling can be either very fast or very slow. To fix this problem
click on the icon at the right edge of the setting to set it to
"Ignore this setting". Then turn your device off and on again.
"Ignore this setting".
The mouse has to be reset (e.g., by turning it off and on again) before this fix will take effect.
- Many gaming mice have both the ONBOARD PROFILES feature and the REPORT RATE feature.
On these mice changing the Polling Rate setting requires modifying a setting in
the ONBOARD PROFILES feature, which can modify how the mouse works. Changing the
Polling Rate setting to "Ignore this setting" (see above) prevents Solaar from
modifying the ONBOARD PROFILES feature. The mouse needs to be turned off and on
again undo the modification of ONBOARD PROFILES feature.
The mouse has to be reset (e.g., by turning it off and on again) before this fix will take effect.
- There are several implementations of the system tray. Some of these have problems
that can result in missing or wrong-sized icons.
## License

13
lib/logitech_receiver/settings_templates.py
View File

@ -540,9 +540,6 @@ def _feature_adjustable_dpi():
def _feature_report_rate_callback(device):
if device.wpid == '408E':
return None # host mode borks the function keys on the G915 TKL keyboard
# Host mode is required for report rate to be adjustable
if _hidpp20.get_onboard_mode(device) != _hidpp20.ONBOARD_MODES.MODE_HOST:
_hidpp20.set_onboard_mode(device, _hidpp20.ONBOARD_MODES.MODE_HOST)
reply = device.feature_request(_F.REPORT_RATE, 0x00)
assert reply, 'Oops, report rate choices cannot be retrieved!'
rate_list = []
@ -553,9 +550,17 @@ def _feature_report_rate_callback(device):
return _ChoicesV(_NamedInts.list(rate_list), byte_count=1) if rate_list else None
class FeatureReortRateRW(_FeatureRW):
def write(self, device, data_bytes):
# Host mode is required for report rate to be adjustable
if _hidpp20.get_onboard_mode(device) != _hidpp20.ONBOARD_MODES.MODE_HOST:
_hidpp20.set_onboard_mode(device, _hidpp20.ONBOARD_MODES.MODE_HOST)
return super().write(device, data_bytes)
def _feature_report_rate():
"""Report Rate feature"""
rw = _FeatureRW(_F.REPORT_RATE, read_fnid=0x10, write_fnid=0x20)
rw = FeatureReortRateRW(_F.REPORT_RATE, read_fnid=0x10, write_fnid=0x20)
return _Setting(_REPORT_RATE, rw, callback=_feature_report_rate_callback, device_kind=(_DK.mouse, ))