From badb76953da4c4c49cee9545b26ad83e9054411e Mon Sep 17 00:00:00 2001
From: MattHag <16444067+MattHag@users.noreply.github.com>
Date: Sun, 13 Oct 2024 11:55:00 +0200
Subject: [PATCH] Test key_is_down

Related #2273
---
 lib/logitech_receiver/diversion.py        | 6 +++---
 tests/logitech_receiver/test_diversion.py | 6 ++++++
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/lib/logitech_receiver/diversion.py b/lib/logitech_receiver/diversion.py
index 7f97e273..8652814a 100644
--- a/lib/logitech_receiver/diversion.py
+++ b/lib/logitech_receiver/diversion.py
@@ -1478,15 +1478,15 @@ built_in_rules = Rule(
 )
 
 
-def key_is_down(key):
+def key_is_down(key: NamedInt) -> bool:
+    """Checks if given key is pressed or not."""
     if key == CONTROL.MR:
         return mr_key_down
     elif CONTROL.M1 <= key <= CONTROL.M8:
         return bool(m_keys_down & (0x01 << (key - CONTROL.M1)))
     elif CONTROL.G1 <= key <= CONTROL.G32:
         return bool(g_keys_down & (0x01 << (key - CONTROL.G1)))
-    else:
-        return key in keys_down
+    return key in keys_down
 
 
 def evaluate_rules(feature, notification: HIDPPNotification, device):
diff --git a/tests/logitech_receiver/test_diversion.py b/tests/logitech_receiver/test_diversion.py
index 48c098c7..dcff0fc8 100644
--- a/tests/logitech_receiver/test_diversion.py
+++ b/tests/logitech_receiver/test_diversion.py
@@ -82,3 +82,9 @@ def test_diversion_rule():
         assert isinstance(key, diversion.Key)
         key = component.components[1]
         assert isinstance(key, diversion.KeyPress)
+
+
+def test_key_is_down():
+    result = diversion.key_is_down(key=diversion.CONTROL.G2)
+
+    assert result is False