RomanNum3ral
/
Solaar
mirror of https://github.com/pwr-Solaar/Solaar.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

config_panel: don't show failed-write alert for unreadable settings 

Write-only HeteroKey settings (e.g. 0x8071 zone effects) legitimately
return None on first read. Gate null_okay on validator.readable so
genuine read failures on readable settings still surface; drop the
unconditional alert in HeteroKeyControl.set_value(None).
This commit is contained in:
Ken Sanislo 2026-05-13 21:24:48 -07:00 committed by Peter F. Patel-Schneider
parent 8760789930
commit e4d543732b
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/solaar/ui/config_panel.py
View File

@ -57,7 +57,8 @@ def _read_async(setting, force_read, sbox, device_is_online, sensitive):
except Exception as e: except Exception as e:
v = None v = None
logger.warning("%s: error reading so use None (%s): %s", s.name, s._device, repr(e)) logger.warning("%s: error reading so use None (%s): %s", s.name, s._device, repr(e))
GLib.idle_add(_update_setting_item, sb, v, online, sensitive, True, priority=99) null_okay = not getattr(getattr(s, "_validator", None), "readable", True)
GLib.idle_add(_update_setting_item, sb, v, online, sensitive, null_okay, priority=99)
ui_async(_do_read, setting, force_read, sbox, device_is_online, sensitive) ui_async(_do_read, setting, force_read, sbox, device_is_online, sensitive)
@ -722,8 +723,6 @@ class HeteroKeyControl(Gtk.HBox, Control):
box.set_rgba(rgba) box.set_rgba(rgba)
else: else:
box.set_value(v) box.set_value(v)
else:
self.sbox._failed.set_visible(True)
self.setup_visibles(id_) self.setup_visibles(id_)
def setup_visibles(self, id_): def setup_visibles(self, id_):