From f4345b9ce013919d98d2935d93e7cc7f9cfc7d21 Mon Sep 17 00:00:00 2001 From: Ken Sanislo Date: Wed, 13 May 2026 15:27:51 -0700 Subject: [PATCH] LogiVoice: hide read-only parameter panels from the UI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Each LogiVoice module exposes both a state toggle and a read-only parameters panel. The toggles are reliable, but the parameters panels only partially decode the GetParameters response — fields not yet identified surface as opaque hex blobs, which adds UI noise without giving the user anything actionable (no write path either). Stop registering the parameters classes in _LOGIVOICE_SETTINGS. The state toggles still register and work as before. Bring the parameter panels back when the wire encoding is fully reverse-engineered and a write path lands. --- lib/logitech_receiver/settings_templates.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/logitech_receiver/settings_templates.py b/lib/logitech_receiver/settings_templates.py index 3c6f5c46..6d5394f2 100644 --- a/lib/logitech_receiver/settings_templates.py +++ b/lib/logitech_receiver/settings_templates.py @@ -2658,9 +2658,11 @@ for _feature in logivoice.PARAMETERS_FIELDS: _state_cls = _logivoice_make_state_class(_feature) if _state_cls is not None: _LOGIVOICE_SETTINGS.append(_state_cls) - _params_cls = _logivoice_make_parameters_class(_feature) - if _params_cls is not None: - _LOGIVOICE_SETTINGS.append(_params_cls) + # Parameters panels are read-only and the wire encoding is only + # partially decoded — hide from the UI until we can write them back. + # _params_cls = _logivoice_make_parameters_class(_feature) + # if _params_cls is not None: + # _LOGIVOICE_SETTINGS.append(_params_cls) class BrightnessControl(settings.Setting):