From fc19860f763ccb65a11f5151457a0a4839a2f765 Mon Sep 17 00:00:00 2001 From: Ken Sanislo Date: Sun, 10 May 2026 16:01:09 -0700 Subject: [PATCH] perkey: label G502 X LEDs by zone id, not letter OpenRGB labels each LED with a letter (A..H) for display; we inherited that convention when porting the G502 X grid. For LEDs without physical keycaps, letters add a mental translation step ("A is zone 1, B is zone 2...") with no visual benefit. Switch to bare zone numbers so the painter cell labels match what shows up in logs, the persister, and rule arguments. --- lib/solaar/ui/perkey/layouts/mouse_g502x.py | 26 ++++++++++----------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/solaar/ui/perkey/layouts/mouse_g502x.py b/lib/solaar/ui/perkey/layouts/mouse_g502x.py index b26fbf41..83c59fae 100644 --- a/lib/solaar/ui/perkey/layouts/mouse_g502x.py +++ b/lib/solaar/ui/perkey/layouts/mouse_g502x.py @@ -16,12 +16,12 @@ """LED layout for the G502 X family (G502 X, G502 X PLUS, G502 X LIGHTSPEED). -Eight LEDs (A..H) reported as zones 1..8 by the firmware. Positions may -need revision per actual hardware. +Eight LEDs reported as zones 1..8 by the firmware. Positions may need +revision per actual hardware. - Row 0: C . . . . . B - Row 1: . D H G F E . - Row 2: . . . . . . A + Row 0: 3 . . . . . 2 + Row 1: . 4 8 7 6 5 . + Row 2: . . . . . . 1 """ from __future__ import annotations @@ -30,14 +30,14 @@ from ..layout import Cell from ..layout import Layout _CELLS: tuple[Cell, ...] = ( - Cell(zone_id=1, row=2, col=6, group="main", label="A"), - Cell(zone_id=2, row=0, col=6, group="main", label="B"), - Cell(zone_id=3, row=0, col=0, group="main", label="C"), - Cell(zone_id=4, row=1, col=1, group="main", label="D"), - Cell(zone_id=5, row=1, col=5, group="main", label="E"), - Cell(zone_id=6, row=1, col=4, group="main", label="F"), - Cell(zone_id=7, row=1, col=3, group="main", label="G"), - Cell(zone_id=8, row=1, col=2, group="main", label="H"), + Cell(zone_id=1, row=2, col=6, group="main", label="1"), + Cell(zone_id=2, row=0, col=6, group="main", label="2"), + Cell(zone_id=3, row=0, col=0, group="main", label="3"), + Cell(zone_id=4, row=1, col=1, group="main", label="4"), + Cell(zone_id=5, row=1, col=5, group="main", label="5"), + Cell(zone_id=6, row=1, col=4, group="main", label="6"), + Cell(zone_id=7, row=1, col=3, group="main", label="7"), + Cell(zone_id=8, row=1, col=2, group="main", label="8"), )