0cd9c0c9b5
Refactor: Introduce Feature enum
...
Convert Feature NamedInts to SupportedFeature integer enum.
Related #2273
2024-10-14 07:28:09 -04:00
06fd32b501
Test and refactor process_notification
...
Related #2273
2024-10-14 07:28:09 -04:00
badb76953d
Test key_is_down
...
Related #2273
2024-10-14 07:28:09 -04:00
a36973916c
settings: check all bits for extended report rate
2024-10-13 20:46:21 -04:00
15659a1ee4
Fix copy-paste error while refactoring notifications.py
2024-10-11 13:23:55 -04:00
194c385824
RuleComponentUI: Type hints methods
2024-10-11 07:42:38 -04:00
d1f9b9ca3d
diversion_rules: Add type hints
2024-10-11 07:42:38 -04:00
97d1e90ceb
Fix signature of show
...
Fix diverged signature of RuleComponentUI subclasses.
2024-10-11 07:42:38 -04:00
9f57955142
Action menu: Move context menu into own class
...
Reduce complexity of diversion dialog.
2024-10-11 07:42:38 -04:00
0dec545bfd
Fix rule saving command
2024-10-11 07:42:38 -04:00
3277015ab6
diversion: Add type hints
2024-10-11 07:42:38 -04:00
bb559c0d7c
base: Remove hard dependency on gi
...
Import gi solely for type checking.
2024-10-11 07:42:38 -04:00
1f85ec01e7
base: Add more unit tests
...
Make internal functions private.
2024-10-11 07:42:38 -04:00
58ddb0d6cd
Introduce HIDAPI protocol
...
Improve type hints and names.
2024-10-11 07:42:38 -04:00
46366b2430
Fix warnings from automatic code inspections
...
Warnings found by automatic code inspection and partially tackled
- Drop distuitls inf favour of setuptools
- Replace deprecated pyudev.Device.from_device_number
- Remove unnecessary brackets
- Avoid access to private variables etc.
- Shadows built-in name
- Line length >120 characters
- Not a module level variable
- Simplify clause
and more
2024-10-11 07:42:38 -04:00
0f4d1aebcd
ui/common: Introduce tests
2024-10-11 07:42:38 -04:00
89233957dc
settings: Add tests
2024-10-11 07:42:38 -04:00
c9e781e752
settings_template: Introduce State enum
2024-10-11 07:42:38 -04:00
54aace050c
Replace action strings with constants
...
Avoids spelling mistakes and helps readability.
2024-10-11 07:42:38 -04:00
cba3533869
Remove factory wrapper classes
...
A module level function is sufficient, no wrapper needed.
2024-10-11 07:42:38 -04:00
ef6b7dec2c
receiver: Remove hard dependency on base
...
With this test all receiver tests are macOS compatible again. The low
level interface supports passing a fake API for unit tests.
2024-10-11 07:42:38 -04:00
4e50e605a6
device: Remove hard dependency on base
2024-10-11 07:42:38 -04:00
614a5dc633
Add type hints and clean up
2024-10-11 07:42:38 -04:00
1729189981
base: Add find_paired_node functions
...
Avoid direct access to hidapi and use the base module as low-level API
instead. This change replaces the remaining calls to find_paired_node
and find_paired_node_wpid by exposing them via base module.
2024-10-11 07:42:38 -04:00
90c41dbe32
base: Add find_paired_node functions
...
Avoid the need for hidapi imports and add them to the base API module.
2024-10-11 07:42:38 -04:00
a7ad625023
Fix about dialog
2024-10-11 07:42:38 -04:00
8d0672ac3c
base_usb: Add external interface
...
Clean up, type hint and tests base_usb and related modules.
2024-10-11 07:42:38 -04:00
a75c4b9679
ui/about: Use Model-View-Presenter pattern for testability
...
Split model and view, and enable view mocks for unit tests without GDK.
2024-10-11 07:42:38 -04:00
46fafa0e68
hidapi: Explicitly load hidapi/udev implementation
...
Linux uses udev, other platforms use the cross-platform hidapi
implementation. Remove implicit loading of hidapi in hidapi/__init__.py.
2024-10-11 07:42:38 -04:00
99fc9c6fcb
receiver: Remove hard dependency on hidapi
2024-10-11 07:42:38 -04:00
615499dce2
device: Remove hard dependency on hidapi
2024-10-11 07:42:38 -04:00
b681aafaff
keysymdef: Rename key symbols
...
Name the key symbol mapping different than the module itself.
2024-10-11 07:42:38 -04:00
4aada31b21
ui: augment pairing message for devices with multiple channels
2024-10-08 15:15:35 -04:00
128ec43d70
solaar: Add type hints
2024-10-08 14:35:16 -04:00
0481950324
base: Add type hints
2024-10-08 14:35:16 -04:00
aa354dc4c4
Replace global sw_id with function call
...
Add test for it.
2024-10-08 14:35:16 -04:00
2442299539
base: Simplify receiver info retrieval
...
- Remove comments with unused receivers
- Simplify receiver hardcoded info
2024-10-08 14:35:16 -04:00
2aa462532a
settings_template: Prepare removal of desktop_notifications dependency
...
Related #2273
2024-10-08 14:35:16 -04:00
d5af19be8a
Make ui/desktop_notifications testable
...
Introduce unit tests.
Related #2273
2024-10-08 14:35:16 -04:00
e8ef262433
Rename ui/notify module to desktop notifications
...
Related #2273
2024-10-08 14:35:16 -04:00
912afff173
Make lr/desktop_notifications testable
...
Introduce unit tests.
Related #2273
2024-10-08 14:35:16 -04:00
0f8ab61ddf
Rename lr/notify module to desktop_notifications
...
Related #2273
2024-10-08 14:35:16 -04:00
3c1aa35067
hidapi: Completely remove dependency on gi
...
Related #2480
2024-10-08 14:35:16 -04:00
8fb087be14
logitech_receiver: Remove GDK dependency
2024-09-15 09:18:51 -04:00
ea0eb66f39
Refactor: Remove all GDK dependencies from hidapi package
...
The hidapi hardware layer must not know or depend on any UI libraries.
Removes all GDK dependencies from the hidapi packages, which makes
testing of these modules easier and removes unwanted cross-dependencies.
Related #2480
2024-09-15 09:18:51 -04:00
70def31942
Refactor: Distinguish module from package
...
Adapt module names to easily distinguish them.
Related #2480
2024-09-15 09:18:51 -04:00
fdd2c79950
settings: allow unkonwn keys in Key rule conditions
2024-08-28 10:40:23 -04:00
ae39ac46ba
docs: improve documentation for cli actions
2024-08-23 20:03:54 -04:00
4578f5f6f1
device: cycle sw_id to better guard against duplication of messages
2024-08-23 19:41:10 -04:00
c07c30baef
device: handle error return on root feature
2024-08-23 19:41:10 -04:00
67829c5807
Clean up imports ( #2537 )
...
* Remove import as _ in solaar startup
Related #2273
* Remove import as _ in listener
Related #2273
* Remove import as _ in cli init
Related #2273
* Remove import as _ in gtk
Related #2273
* Remove import as _ in show
Related #2273
* Remove import as _ in tray
Related #2273
* Remove import as _ in profiles
Related #2273
* Remove import as _ in config
Related #2273
* Remove import as _ in config panel
Related #2273
* Remove import as _ in window
Related #2273
* Remove import as _ in pair
Related #2273
* Remove import as _ in pair window
Related #2273
* Remove import as _ in cli package
Related #2273
* Remove import as _ in ui package
Related #2273
* Remove commented out code
Related #2273
* Use constant for Logitech ID
2024-07-15 08:37:18 -04:00
d9d67ed738
device: handle unknown device kinds
2024-07-02 10:59:16 -04:00
8ab8cb0225
docs: Update about.py ( #2535 )
...
Update copyright date in about page to reflect current year (2024)
Follow-up to #2074
2024-06-23 17:56:52 -04:00
3aa064b40f
settings: finish change to new constants
2024-06-13 10:01:50 -04:00
db93e9ab10
hidapi: remove check on driver
2024-06-13 07:44:47 -04:00
a7784b40ab
cli: finish change to show.py for new constants
2024-06-13 05:54:36 -04:00
86b55b9c25
Introduce Enum BusID
...
Distinguishes Bluetooth and USB devices.
2024-06-03 08:37:02 -04:00
7f5e156fa1
Introduce constant for Logitech vendor ID
...
The Vendor ID for Logitech is 0x46D = 1133.
2024-06-03 08:37:02 -04:00
d67466298b
Introduce Enum for notification types
2024-06-03 08:37:02 -04:00
9726b93a78
Improve base module
...
Use clearer names and type hints.
2024-06-03 08:37:02 -04:00
e316ed1bc2
Remove unnecessary receiver info 'hid_driver'
...
The same constant is used everywhere.
2024-06-03 08:37:02 -04:00
a5ded24057
Convert HIDPPNotification to dataclass
...
Replaces the very last namedtuple.
2024-06-03 08:37:02 -04:00
2113e63a75
device: be defensive when converting battery status to string
2024-06-03 08:33:11 -04:00
be83dac209
hid: Convert definition of HID registers to enum
...
* Refactor HID Register definitions
Use enums for distinct type hints, easy discovery of registers.
Make constants uppercase and benefit from enum auto-completion.
Related #2273
* Improve type hints: Registers
2024-06-02 10:34:00 -04:00
c23ebcd267
Use double quotes for module level docstrings
...
Make module level docstrings distinguishable from license text.
Related #2273
2024-06-02 09:54:21 -04:00
5a63e44d58
Remove empty comment lines
...
Remove hashtags solely used for structuring.
Related #2273
2024-06-02 09:54:21 -04:00
244d0ee88a
solaar: clean up locale code
...
Usage example for German:
LC_ALL=de_DE.UTF-8 solaar
Related #2507
2024-06-01 12:09:55 -04:00
c29231bc6b
refactor: Creation of devices ( #2493 )
...
* Refine interfaces for testability
* Reenable fixed device tests
2024-05-27 11:58:16 -04:00
815dce07be
Unify imports in logitech package
...
Related #2273
2024-05-23 16:42:18 -04:00
90b0db6c3b
device: don't ping device when getting name or codename
2024-05-22 21:22:08 -04:00
c9dc232951
Refactor: Use dataclasses and enums
...
Replace unnecessary NamedInts in favour of default data types.
Simplify interfaces by reducing possible input from strings to members
of an enum.
2024-05-22 21:14:41 -04:00
469c04faaf
Introduce Device protocol and type hints
2024-05-22 21:14:41 -04:00
193dbfda21
hidpp10: Move independent functions to module level
2024-05-22 21:14:41 -04:00
7d171b1d09
Refactor: Use dataclasses and enums
...
Replace NamedTuples with more flexible dataclass, which also support
type hints. Introduce enums to replace constant strings, which need to
be kept in sync. Also enhances interfaces by limiting it to the enum
values. Remove unused variables.
2024-05-22 21:14:41 -04:00
500b9998c5
Fix macOS compatibility and reenable CI tests
...
* Fix CI for macOS
* Fix error message for missing hidapi
* Skip some device and receiver tests on macOS
Tests fail on macOS, enable them when unit tests are
refined to only test the module without dependencies.
* Safe guard dbus import
2024-05-22 18:45:40 -04:00
d0a3e474c7
hidapi: Unify imports in hidapi package ( #2487 )
...
Remove all 'import xyz as _xyz' and favor import of module name to
get more context in the code.
Related #2273
2024-05-16 15:58:22 -04:00
b321167304
Drop support for end-of-life Python 3.7
...
* Drop support for end-of-life Python 3.7
* Remove handling of code for Python 3.7 and older
2024-05-11 11:48:32 -04:00
ea77335ecf
release 1.1.13
2024-05-11 11:35:41 -04:00
f30999a96a
release 1.1.13rc1
2024-05-08 14:37:55 -04:00
6c11f4e480
solaar: fix bug in suspend and resume callback
2024-05-08 08:05:00 -04:00
1dfc4bdb1c
settings: add choices universe for backlight setting
2024-05-08 08:05:00 -04:00
1d5b61fbf2
diversion: Simplify and type hint
...
- Make static method an easy testable function.
- Fix variable name clashes
2024-05-05 10:43:39 -04:00
3ffa4e30f1
settings: get and use current host number for K375sFnSwap because of bug in firmware of MX Keys S
2024-05-04 04:46:27 -04:00
b4811f602d
ui: fix bug with logo in about window
2024-05-04 04:46:27 -04:00
37aa0963da
solaar: don't ping device just to get logging information
2024-05-04 04:46:27 -04:00
da1cb53c1b
settings: optimize write for per-key lighting
2024-05-03 11:54:24 -04:00
e5967edc66
settings: add and initialize per-key lighting to a special no-change value
2024-05-03 11:54:24 -04:00
704a87696f
hidapi: Remove Python 2 compatibility ( #2460 )
...
Related #2273
2024-04-30 08:19:50 -04:00
959dd2a35b
Refactor rule loading for testability ( #2456 )
...
rules: Introduce tests for YAML rule loading functionality.
2024-04-27 17:56:27 -04:00
22a59b6b0b
release 1.1.12
2024-04-27 17:51:04 -04:00
3160e3b3d6
release 1.1.12rc2
2024-04-22 12:13:46 -04:00
932bc5cb0e
device: check for existences of keys file before opening
2024-04-21 17:37:10 -04:00
4225fce8d7
po: update Russion translation and have all strings translated
...
* update Russian translation
* Fixed translation display in GUI
* fix checks / Fixed translation display in GUI
2024-04-21 11:36:39 -04:00
cf038fd982
settings: improve label and description for LED zone settings
2024-04-19 16:05:29 -04:00
7bef5c046c
settings: add message about Onboard Profiles to LED Zone settings
2024-04-19 16:05:29 -04:00
c4e2a5683a
device: initialize device registers to empty list
2024-04-19 16:05:29 -04:00
08c748c593
release 1.1.12rc1
2024-04-19 03:54:54 -04:00
e667d41c7b
solaar: use bluez dbus signals to disconnect and connect bluetooth devices
2024-04-18 20:32:40 -04:00
d7ce636917
device: handle a different signal for onboard profiles directory in ROM
2024-04-15 14:40:50 -04:00
86bab897d1
receiver: introduce small delay in getting pairing information to let receiver settle after pairing
2024-04-15 14:40:50 -04:00
MattHag
Peter F. Patel-Schneider
rloutrel
Anderson Silva
MistificaT0r