d561d9f70d
IntEnum members with the same int value hash equal and compare equal, so a dict lookup for SupportedFeature.DEVICE_NAME (0x0005) finds an entry stored as CenturionCoreFeature.MULTI_HOST_CONTROL (same 0x0005). The index is right for the Centurion feature but wrong for the HID++ 2.0 feature the caller intended. Concrete impact: `solaar show` on wired G522 called get_kind() -> feature_request(DEVICE_NAME, 0x20), which resolved to MULTI_HOST_CONTROL.function_2 via the collision, and the device returned OUT_OF_RANGE -> FeatureCallError crashed `solaar show`. Fix: in Device.feature_request, after resolving the index, compare the type of the stored inverse entry against the type of the requested feature. Mismatched types mean the device actually has the Centurion variant, not the HID++ 2.0 feature — return None instead of issuing a mis-targeted request. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| base.py | ||
| base_usb.py | ||
| centurion.py | ||
| centurion_constants.py | ||
| common.py | ||
| descriptors.py | ||
| desktop_notifications.py | ||
| device.py | ||
| diversion.py | ||
| exceptions.py | ||
| hidpp10.py | ||
| hidpp10_constants.py | ||
| hidpp20.py | ||
| hidpp20_constants.py | ||
| i18n.py | ||
| listener.py | ||
| notifications.py | ||
| onboard_eq.py | ||
| receiver.py | ||
| settings.py | ||
| settings_new.py | ||
| settings_templates.py | ||
| settings_validator.py | ||
| special_keys.py | ||