From 26007fd686502f6be14ec4d8fc8c7ba2a5e2874d Mon Sep 17 00:00:00 2001 From: philjn Date: Sun, 19 Apr 2026 08:21:13 -0700 Subject: [PATCH] fix: check-deps.ps1 jadx fallback path version check, decompile.md lint fixes --- plugins/android-reverse-engineering/commands/decompile.md | 4 ++++ .../skills/android-reverse-engineering/scripts/check-deps.ps1 | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/android-reverse-engineering/commands/decompile.md b/plugins/android-reverse-engineering/commands/decompile.md index 2489b82..34c888e 100644 --- a/plugins/android-reverse-engineering/commands/decompile.md +++ b/plugins/android-reverse-engineering/commands/decompile.md @@ -46,16 +46,19 @@ After any installations, re-run `check-deps.sh` to verify. Do not proceed until Run the decompile script on the target file. Choose the engine based on the input: - **APK or XAPK** → use jadx first (handles resources natively; XAPK is auto-extracted): + ```bash bash ${CLAUDE_PLUGIN_ROOT}/skills/android-reverse-engineering/scripts/decompile.sh ``` - **JAR/AAR** and Fernflower is available → prefer fernflower for better Java output: + ```bash bash ${CLAUDE_PLUGIN_ROOT}/skills/android-reverse-engineering/scripts/decompile.sh --engine fernflower ``` - **If jadx output has warnings** or the user wants the best quality → run both and compare: + ```bash bash ${CLAUDE_PLUGIN_ROOT}/skills/android-reverse-engineering/scripts/decompile.sh --engine both ``` @@ -79,6 +82,7 @@ After decompilation completes: ### Step 5: Offer next steps Tell the user what they can do next: + - **Trace call flows**: "I can follow the execution flow from any Activity to its API calls" - **Extract APIs**: "I can search for all HTTP endpoints and document them" - **Analyze specific classes**: "Point me to a specific class or feature to analyze" diff --git a/plugins/android-reverse-engineering/skills/android-reverse-engineering/scripts/check-deps.ps1 b/plugins/android-reverse-engineering/skills/android-reverse-engineering/scripts/check-deps.ps1 index 4174507..3ced181 100644 --- a/plugins/android-reverse-engineering/skills/android-reverse-engineering/scripts/check-deps.ps1 +++ b/plugins/android-reverse-engineering/skills/android-reverse-engineering/scripts/check-deps.ps1 @@ -68,7 +68,8 @@ if (-not $jadxBin) { } if ($jadxBin) { try { - $jadxVersion = & jadx --version 2>$null + $jadxCmd = if ($jadxBin -is [string]) { $jadxBin } else { 'jadx' } + $jadxVersion = & $jadxCmd --version 2>$null Write-Host "[OK] jadx $jadxVersion detected" } catch { Write-Host "[OK] jadx detected"