From 2825818af66f7ccf865ceea0e8ea39933601a875 Mon Sep 17 00:00:00 2001 From: correctmost <134317971+correctmost@users.noreply.github.com> Date: Sat, 30 Nov 2024 03:59:28 -0500 Subject: [PATCH] Enable useless-parent-delegation pylint rule and fix warnings (#2962) --- archinstall/default_profiles/desktops/cutefish.py | 9 +-------- archinstall/default_profiles/desktops/hyprland.py | 5 ----- archinstall/default_profiles/desktops/sway.py | 5 ----- pyproject.toml | 1 - 4 files changed, 1 insertion(+), 19 deletions(-) diff --git a/archinstall/default_profiles/desktops/cutefish.py b/archinstall/default_profiles/desktops/cutefish.py index f8a1a402..21228b10 100644 --- a/archinstall/default_profiles/desktops/cutefish.py +++ b/archinstall/default_profiles/desktops/cutefish.py @@ -1,11 +1,8 @@ -from typing import TYPE_CHECKING, override +from typing import override from archinstall.default_profiles.profile import GreeterType, ProfileType from archinstall.default_profiles.xorg import XorgProfile -if TYPE_CHECKING: - from archinstall.lib.installer import Installer - class CutefishProfile(XorgProfile): def __init__(self) -> None: @@ -23,7 +20,3 @@ class CutefishProfile(XorgProfile): @override def default_greeter_type(self) -> GreeterType | None: return GreeterType.Sddm - - @override - def install(self, install_session: 'Installer') -> None: - super().install(install_session) diff --git a/archinstall/default_profiles/desktops/hyprland.py b/archinstall/default_profiles/desktops/hyprland.py index f5f7b43d..598d14f0 100644 --- a/archinstall/default_profiles/desktops/hyprland.py +++ b/archinstall/default_profiles/desktops/hyprland.py @@ -8,7 +8,6 @@ from archinstall.tui import Alignment, FrameProperties, MenuItem, MenuItemGroup, if TYPE_CHECKING: from collections.abc import Callable - from archinstall.lib.installer import Installer from archinstall.lib.translationhandler import DeferredTranslation _: Callable[[str], DeferredTranslation] @@ -76,7 +75,3 @@ class HyprlandProfile(XorgProfile): def do_on_select(self) -> SelectResult | None: self._ask_seat_access() return None - - @override - def install(self, install_session: 'Installer') -> None: - super().install(install_session) diff --git a/archinstall/default_profiles/desktops/sway.py b/archinstall/default_profiles/desktops/sway.py index 9b236df0..c55081d9 100644 --- a/archinstall/default_profiles/desktops/sway.py +++ b/archinstall/default_profiles/desktops/sway.py @@ -8,7 +8,6 @@ from archinstall.tui import Alignment, FrameProperties, MenuItem, MenuItemGroup, if TYPE_CHECKING: from collections.abc import Callable - from archinstall.lib.installer import Installer from archinstall.lib.translationhandler import DeferredTranslation _: Callable[[str], DeferredTranslation] @@ -85,7 +84,3 @@ class SwayProfile(XorgProfile): def do_on_select(self) -> SelectResult | None: self._ask_seat_access() return None - - @override - def install(self, install_session: 'Installer') -> None: - super().install(install_session) diff --git a/pyproject.toml b/pyproject.toml index 9a89afd6..957a3594 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -176,7 +176,6 @@ disable = [ "unspecified-encoding", "unused-argument", "unused-variable", - "useless-parent-delegation", ] [tool.pylint.refactoring]