RomanNum3ral
/
archinstall
mirror of https://github.com/archlinux/archinstall.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary else in try...except 

This change simplifies the try...except block in generic_select by adding a break to the item selection by index
This commit is contained in:
SecondThundeR 2021-04-23 01:08:38 +03:00
parent 839e945b87
commit 2d3d3c54ef
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
archinstall/lib/user_interaction.py
View File

@ -277,7 +277,7 @@ def generic_select(options, input_text="Select one of the above by index or abso
print(f"{index}: {option}") print(f"{index}: {option}")
# The new changes introduce a single while loop for all inputs processed by this function # The new changes introduce a single while loop for all inputs processed by this function
# Now the try...except...else block handles validation for invalid input from the user # Now the try...except block handles validation for invalid input from the user
while True: while True:
try: try:
selected_option = input(input_text) selected_option = input(input_text)
@ -293,6 +293,7 @@ def generic_select(options, input_text="Select one of the above by index or abso
if selected_option >= len(options): if selected_option >= len(options):
raise RequirementError(f'Selected option "{selected_option}" is out of range') raise RequirementError(f'Selected option "{selected_option}" is out of range')
selected_option = options[selected_option] selected_option = options[selected_option]
break
elif selected_option in options: elif selected_option in options:
break # We gave a correct absolute value break # We gave a correct absolute value
else: else:
@ -300,8 +301,6 @@ def generic_select(options, input_text="Select one of the above by index or abso
except RequirementError as err: except RequirementError as err:
log(f" * {err} * ", fg='red') log(f" * {err} * ", fg='red')
continue continue
else:
break
return selected_option return selected_option