Switched plugin strategty. Now uses built-in entrypoints to source and load the plugins. This is the default method provided by Python, and is the cleanest so far I think.

archinstall/lib/plugins.py

@@ -1,24 +1,10 @@
-import pkgutil
+from importlib import metadata
-import importlib
-import imp # Deprecated
-from .storage import storage
 
 plugins = {}
-PLUGIN_PREFIXES = 'archinstall-'
 
-if (plugin_list := storage.get('plugins', None)):
+# 1: List archinstall.plugin definitions
-	if type(plugin_list) == str and plugin_list != '*':
+# 2: Loade the plugin entry point
-		plugin_list = plugin_list.split(',')
+# 3: Initiate the plugin and store it as .name in plugins
-
+for plugin_definition in metadata.entry_points()['archinstall.plugin']:
-	for module_info in pkgutil.iter_modules(path=None, prefix=''):
+	plugin_entrypoint = plugin_definition.load()
-		if not module_info.ispkg:
+	plugins[plugin_definition.name] = plugin_entrypoint()
-			continue
-
-		# If --plugins=* and <iterator:plugin> == 'archinstall-'
-		#  of --plugins=name is <iterator:plugin>
-		if (plugin_list == '*' and PLUGIN_PREFIXES in module_info.name) or (module_info.name in plugin_list):
-			try:
-				modulesource = importlib.import_module(module_info.name)
-				imp.reload(modulesource)
-			except Exception as e:
-				print('Could not load plugin {} {}'.format(modname, e))