From 2f344a84ff6f7e1f28d133ebc591b2a6f725dbe9 Mon Sep 17 00:00:00 2001 From: codefiles <11915375+codefiles@users.noreply.github.com> Date: Tue, 21 Jul 2026 06:50:56 -0400 Subject: [PATCH] Remove redundant is_valid_path (#4646) --- archinstall/lib/args.py | 7 +++---- archinstall/lib/utils/util.py | 5 ----- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/archinstall/lib/args.py b/archinstall/lib/args.py index 95869c2f..3d372625 100644 --- a/archinstall/lib/args.py +++ b/archinstall/lib/args.py @@ -35,7 +35,6 @@ from archinstall.lib.models.users import Password, User, UserSerialization from archinstall.lib.plugins import load_plugin from archinstall.lib.translationhandler import Language, tr, translation_handler from archinstall.lib.utils.format import as_key_value_pair -from archinstall.lib.utils.util import is_valid_path from archinstall.lib.version import get_version from archinstall.tui.components import tui @@ -404,7 +403,7 @@ class ArchConfig: ) -> None: save_path = dest_path or DEFAULT_SAVE_PATH - if not is_valid_path(save_path): + if not save_path.is_dir(): warn( f'Destination directory {save_path} does not exist or is not a directory\n.', 'Configuration files can not be saved', @@ -416,7 +415,7 @@ class ArchConfig: self.save_user_creds(save_path, password=password) def save_user_config(self, dest_path: Path) -> None: - if not is_valid_path(dest_path): + if not dest_path.is_dir(): error(f'Invalid path {dest_path}. User configuration could not be saved.') return @@ -430,7 +429,7 @@ class ArchConfig: dest_path: Path, password: str | None = None, ) -> None: - if not is_valid_path(dest_path): + if not dest_path.is_dir(): error(f'Invalid path {dest_path}. User credentials could not be saved.') return diff --git a/archinstall/lib/utils/util.py b/archinstall/lib/utils/util.py index a0c34f5f..f94ca18c 100644 --- a/archinstall/lib/utils/util.py +++ b/archinstall/lib/utils/util.py @@ -1,7 +1,6 @@ import secrets import string from datetime import UTC, datetime -from pathlib import Path from archinstall.lib.pathnames import ARCHISO_MOUNTPOINT from archinstall.lib.utils.format import as_columns @@ -47,7 +46,3 @@ def format_cols(items: list[str], header: str | None = None) -> str: # remove whitespaces on each row text = '\n'.join(t.strip() for t in text.split('\n')) return text - - -def is_valid_path(path: Path) -> bool: - return path.exists() and path.is_dir()