RomanNum3ral
/
archinstall
mirror of https://github.com/archlinux/archinstall.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Warn when a desktop profile's greeter can't log in without a regular user (#4331)

This commit is contained in:
Dylan M. Taylor 2026-03-30 19:48:01 -04:00 committed by GitHub
parent e3e9563aa6
commit 603c432e18
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
archinstall/lib/global_menu.py
View File

@ -1,5 +1,6 @@
from typing import override from typing import override
from archinstall.default_profiles.profile import GreeterType
from archinstall.lib.applications.application_menu import ApplicationMenu from archinstall.lib.applications.application_menu import ApplicationMenu
from archinstall.lib.args import ArchConfig from archinstall.lib.args import ArchConfig
from archinstall.lib.authentication.authentication_menu import AuthenticationMenu from archinstall.lib.authentication.authentication_menu import AuthenticationMenu
@ -207,6 +208,11 @@ class GlobalMenu(AbstractMenu[None]):
return any([u.sudo for u in auth_config.users]) return any([u.sudo for u in auth_config.users])
return False return False
def has_regular_user() -> bool:
if auth_config and auth_config.users:
return len(auth_config.users) > 0
return False
missing = set() missing = set()
if (auth_config is None or auth_config.root_enc_password is None) and not has_superuser(): if (auth_config is None or auth_config.root_enc_password is None) and not has_superuser():
@ -214,6 +220,18 @@ class GlobalMenu(AbstractMenu[None]):
tr('Either root-password or at least 1 user with sudo privileges must be specified'), tr('Either root-password or at least 1 user with sudo privileges must be specified'),
) )
# These greeters only show users with UID >= 1000 and have no manual login by default
if not has_regular_user():
profile_item: MenuItem = self._item_group.find_by_key('profile_config')
profile_config: ProfileConfiguration | None = profile_item.value
if profile_config and profile_config.profile and profile_config.profile.is_desktop_profile():
problematic_greeters = {GreeterType.Sddm}
if any(p.default_greeter_type in problematic_greeters for p in profile_config.profile.current_selection):
missing.add(
tr('The selected desktop profile requires a regular user to log in via the greeter'),
)
for item in self._item_group.items: for item in self._item_group.items:
if item.mandatory: if item.mandatory:
assert item.key is not None assert item.key is not None