From 624143ed96418fa223f6bd227f2a5ec6951cbd10 Mon Sep 17 00:00:00 2001
From: correctmost <134317971+correctmost@users.noreply.github.com>
Date: Mon, 10 Mar 2025 07:03:29 -0400
Subject: [PATCH] Speed up clear_vt100_escape_codes by caching an encode()
 result (#3238)

This commit helps avoid ~280,000 redundant encode() calls when
opening the additional packages menu.
---
 archinstall/lib/general.py | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/archinstall/lib/general.py b/archinstall/lib/general.py
index 5c8119db..65130dc9 100644
--- a/archinstall/lib/general.py
+++ b/archinstall/lib/general.py
@@ -28,6 +28,10 @@ from .storage import storage
 if TYPE_CHECKING:
 	from .installer import Installer
 
+# https://stackoverflow.com/a/43627833/929999
+_VT100_ESCAPE_REGEX = r'\x1B\[[?0-9;]*[a-zA-Z]'
+_VT100_ESCAPE_REGEX_BYTES = _VT100_ESCAPE_REGEX.encode()
+
 
 def generate_password(length: int = 64) -> str:
 	haystack = string.printable  # digits, ascii_letters, punctuation (!"#$[] etc) and whitespace
@@ -41,11 +45,9 @@ def locate_binary(name: str) -> str:
 
 
 def clear_vt100_escape_codes(data: bytes | str) -> bytes | str:
-	# https://stackoverflow.com/a/43627833/929999
-	vt100_escape_regex = r'\x1B\[[?0-9;]*[a-zA-Z]'
 	if isinstance(data, bytes):
-		return re.sub(vt100_escape_regex.encode(), b'', data)
-	return re.sub(vt100_escape_regex, '', data)
+		return re.sub(_VT100_ESCAPE_REGEX_BYTES, b'', data)
+	return re.sub(_VT100_ESCAPE_REGEX, '', data)
 
 
 def jsonify(obj: Any, safe: bool = True) -> Any: