From 8fb83a7bebe9192fac3988230fbd2a1fe0dc3fb6 Mon Sep 17 00:00:00 2001
From: correctmost <134317971+correctmost@users.noreply.github.com>
Date: Mon, 13 Oct 2025 05:03:00 -0400
Subject: [PATCH] Upgrade Pylint to 4.0.0 (#3867)

This commit also removes the pylint-pydantic plug-in, which is not
yet compatible with Pylint v4.
---
 .github/workflows/pylint.yaml   | 2 +-
 PKGBUILD                        | 1 -
 archinstall/lib/models/users.py | 2 ++
 pyproject.toml                  | 4 +---
 4 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/pylint.yaml b/.github/workflows/pylint.yaml
index 4445338a..4c7b5154 100644
--- a/.github/workflows/pylint.yaml
+++ b/.github/workflows/pylint.yaml
@@ -14,7 +14,7 @@ jobs:
                 pacman --noconfirm -Syyu
                 pacman --noconfirm -Sy python-pip python-pyparted pkgconfig gcc
             - run: pip install --break-system-packages --upgrade pip
-            - name: Install Pylint and Pylint plug-ins
+            - name: Install Pylint
               run: pip install --break-system-packages .[dev]
             - run: python --version
             - run: pylint --version
diff --git a/PKGBUILD b/PKGBUILD
index 8448152d..ddc36c81 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -43,7 +43,6 @@ makedepends=(
   'python-wheel'
   'python-sphinx_rtd_theme'
   'python-pylint'
-  'python-pylint-pydantic'
   'ruff'
 )
 optdepends=(
diff --git a/archinstall/lib/models/users.py b/archinstall/lib/models/users.py
index 3f18f52d..74ede0c5 100644
--- a/archinstall/lib/models/users.py
+++ b/archinstall/lib/models/users.py
@@ -45,6 +45,8 @@ class PasswordStrength(Enum):
 		symbol = any(not character.isalnum() for character in password)
 		return cls._check_password_strength(digit, upper, lower, symbol, len(password))
 
+	# TODO: Remove the disable line when https://github.com/pylint-dev/pylint/issues/10647 is fixed
+	# pylint: disable=bare-name-capture-pattern
 	@classmethod
 	def _check_password_strength(
 		cls,
diff --git a/pyproject.toml b/pyproject.toml
index 1d63f03e..42a72edc 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -35,8 +35,7 @@ dev = [
     "flake8==7.3.0",
     "pre-commit==4.3.0",
     "ruff==0.14.0",
-    "pylint==3.3.9",
-    "pylint-pydantic==0.3.5",
+    "pylint==4.0.0",
     "pytest==8.4.2",
 ]
 doc = ["sphinx"]
@@ -137,7 +136,6 @@ ignore-paths = [
     "^build/",
     "^docs/",
 ]
-load-plugins = ["pylint_pydantic"]
 persistent = false
 py-version = "3.12"
 recursive = true