From a28fb27a7a4cdb54f703c6ec281606f8861ebe2c Mon Sep 17 00:00:00 2001 From: correctmost <134317971+correctmost@users.noreply.github.com> Date: Tue, 26 Nov 2024 14:48:38 -0500 Subject: [PATCH] Use human-friendly names in mypy and Pylint ignore directives (#2946) --- archinstall/lib/disk/fido.py | 2 +- archinstall/lib/general.py | 2 +- archinstall/lib/output.py | 2 +- archinstall/lib/translationhandler.py | 4 ++-- archinstall/tui/curses_menu.py | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/archinstall/lib/disk/fido.py b/archinstall/lib/disk/fido.py index dd053adb..6457e41a 100644 --- a/archinstall/lib/disk/fido.py +++ b/archinstall/lib/disk/fido.py @@ -42,7 +42,7 @@ class Fido2: error('fido2 support is most likely not installed') raise ValueError('HSM devices can not be detected, is libfido2 installed?') - fido_devices: str = clear_vt100_escape_codes(ret) # type: ignore + fido_devices: str = clear_vt100_escape_codes(ret) # type: ignore[assignment] manufacturer_pos = 0 product_pos = 0 diff --git a/archinstall/lib/general.py b/archinstall/lib/general.py index d79b2d27..c5784d9c 100644 --- a/archinstall/lib/general.py +++ b/archinstall/lib/general.py @@ -156,7 +156,7 @@ class SysCommandWorker: lines = filter(None, self._trace_log[self._trace_log_pos:last_line].splitlines()) for line in lines: if self.remove_vt100_escape_codes_from_lines: - line = clear_vt100_escape_codes(line) # type: ignore + line = clear_vt100_escape_codes(line) # type: ignore[assignment] yield line + b'\n' diff --git a/archinstall/lib/output.py b/archinstall/lib/output.py index 1b5f67e3..87e5b299 100644 --- a/archinstall/lib/output.py +++ b/archinstall/lib/output.py @@ -133,7 +133,7 @@ class Journald: @staticmethod def log(message: str, level: int = logging.DEBUG) -> None: try: - import systemd.journal # type: ignore + import systemd.journal # type: ignore[import-not-found] except ModuleNotFoundError: return None diff --git a/archinstall/lib/translationhandler.py b/archinstall/lib/translationhandler.py index 08e6581c..ca150184 100644 --- a/archinstall/lib/translationhandler.py +++ b/archinstall/lib/translationhandler.py @@ -111,7 +111,7 @@ class TranslationHandler: """ # this is a very naughty way of retrieving the data but # there's no alternative method exposed unfortunately - catalog = translation._catalog # type: ignore + catalog = translation._catalog # type: ignore[attr-defined] messages = {k: v for k, v in catalog.items() if k and v} return len(messages) @@ -205,7 +205,7 @@ class DeferredTranslation: @classmethod def install(cls) -> None: import builtins - builtins._ = cls # type: ignore + builtins._ = cls # type: ignore[attr-defined] translation_handler = TranslationHandler() diff --git a/archinstall/tui/curses_menu.py b/archinstall/tui/curses_menu.py index 3cd73923..c99f1bcc 100644 --- a/archinstall/tui/curses_menu.py +++ b/archinstall/tui/curses_menu.py @@ -394,7 +394,7 @@ class EditViewport(AbstractViewport): self._textbox = curses.textpad.Textbox(self._edit_win) self._main_win.refresh() - self._textbox.edit(self.process_key) # type: ignore + self._textbox.edit(self.process_key) # type: ignore[arg-type] @dataclass @@ -1481,8 +1481,8 @@ class Tui: return Tui.t()._main_loop(component) def _sig_win_resize(self, signum: int, frame: FrameType | None) -> None: - if hasattr(self, '_component') and self._component is not None: # pylint: disable=E1101 - self._component.resize_win() # pylint: disable=E1101 + if hasattr(self, '_component') and self._component is not None: # pylint: disable=no-member + self._component.resize_win() # pylint: disable=no-member def _main_loop(self, component: AbstractCurses) -> Result: self._screen.refresh()