From a5d995b5468faad343a7af1802c88da84b678a2f Mon Sep 17 00:00:00 2001 From: correctmost <134317971+correctmost@users.noreply.github.com> Date: Fri, 30 May 2025 08:42:00 +0000 Subject: [PATCH] Remove underscore from _FrameDim because it's used externally (#3547) This commit fixes a reportUnusedClass warning from Pyright. --- archinstall/tui/curses_menu.py | 14 +++++++------- archinstall/tui/types.py | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/archinstall/tui/curses_menu.py b/archinstall/tui/curses_menu.py index a63a5866..545a553b 100644 --- a/archinstall/tui/curses_menu.py +++ b/archinstall/tui/curses_menu.py @@ -21,13 +21,13 @@ from .types import ( STYLE, Alignment, Chars, + FrameDim, FrameProperties, FrameStyle, MenuKeys, Orientation, PreviewStyle, ViewportEntry, - _FrameDim, ) @@ -158,7 +158,7 @@ class AbstractViewport: def _get_right_frame( self, - dim: _FrameDim, + dim: FrameDim, scroll_percentage: int | None = None, ) -> list[ViewportEntry]: right_frame = {} @@ -181,7 +181,7 @@ class AbstractViewport: def _get_top( self, - dim: _FrameDim, + dim: FrameDim, h_bar: str, frame: FrameProperties, scroll_percentage: int | None = None, @@ -197,7 +197,7 @@ class AbstractViewport: def _get_bottom( self, - dim: _FrameDim, + dim: FrameDim, h_bar: str, scroll_pct: int | None = None, ) -> ViewportEntry: @@ -214,7 +214,7 @@ class AbstractViewport: max_width: int, max_height: int, frame: FrameProperties, - ) -> _FrameDim: + ) -> FrameDim: rows = self._assemble_entries(entries).split('\n') header_len = len(frame.header) if frame.header else 0 header_len += 3 # for header padding @@ -237,12 +237,12 @@ class AbstractViewport: frame_end = max_width frame_height = max_height - 1 - return _FrameDim(frame_start, frame_end, frame_height) + return FrameDim(frame_start, frame_end, frame_height) def _adjust_entries( self, entries: list[ViewportEntry], - frame_dim: _FrameDim, + frame_dim: FrameDim, ) -> list[ViewportEntry]: for entry in entries: # top row frame offset diff --git a/archinstall/tui/types.py b/archinstall/tui/types.py index a11a3af0..10697e79 100644 --- a/archinstall/tui/types.py +++ b/archinstall/tui/types.py @@ -134,7 +134,7 @@ class Alignment(Enum): @dataclass -class _FrameDim: +class FrameDim: x_start: int x_end: int height: int