From bcc3d18a0a857abc4877a90ffe472102d9f3dbf0 Mon Sep 17 00:00:00 2001 From: Victor Date: Wed, 12 Aug 2026 00:48:20 -0300 Subject: [PATCH] Fail the partition test when the example config has none The loops in test_example_config_partitions would not execute if device_modifications or a device's partitions were empty, so the test could pass while checking nothing. --- tests/test_args.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/test_args.py b/tests/test_args.py index 100d1044..685c01ff 100644 --- a/tests/test_args.py +++ b/tests/test_args.py @@ -420,11 +420,18 @@ def test_example_config_partitions(example_config_fixture: Path) -> None: # partition entries are only parsed when the configured device is present on # the machine, which is never the case in CI, so read them here directly config = json.loads(example_config_fixture.read_text()) + device_modifications = config['disk_config']['device_modifications'] + + assert device_modifications + + for device in device_modifications: + partitions = device['partitions'] + + assert partitions - for device in config['disk_config']['device_modifications']: previous_end = None - for partition in device['partitions']: + for partition in partitions: assert 'dev_path' in partition start = Size.parse_args(partition['start'])