RomanNum3ral
/
archinstall
mirror of https://github.com/archlinux/archinstall.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove GRUB removable fallback path (#3971) 

As mentioned by @svartkanin on #3950, given we now have a way for the user to
explicitly specify if they want to install to the removable location, having a
fallback like this seems undesirable.

On top of that, as mentioned by @correctmost on the same PR, the code that said
PR introduced was bugged and would always raise an exception anyways.
This commit is contained in:
Mintsuki 2025-12-05 10:05:24 +01:00 committed by GitHub
parent 66fb49617a
commit d176b9514c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
archinstall/lib/installer.py
View File

@ -1321,14 +1321,7 @@ class Installer:
try: try:
SysCommand(command, peek_output=True) SysCommand(command, peek_output=True)
except SysCallError as err: except SysCallError as err:
if not bootloader_removable: raise DiskError(f'Could not install GRUB to {self.target}{efi_partition.mountpoint}: {err}')
command.append('--removable')
try:
SysCommand(command, peek_output=True)
except SysCallError:
pass
raise DiskError(f'Could not install GRUB to {self.target}{efi_partition.mountpoint}: {err}') from err
else: else:
info(f'GRUB boot partition: {boot_partition.dev_path}') info(f'GRUB boot partition: {boot_partition.dev_path}')