From e4b2894db5e8391aee958a347bbc984edb63c0ab Mon Sep 17 00:00:00 2001 From: brurmonemt Date: Sun, 28 Jun 2026 14:19:42 -0500 Subject: [PATCH] fix ValueError exception when no disks are detected in the disk menu (#4598) * Fix ValueError exception when no disks are detected in the disk menu in lib/disk/disk_menu.py, the menu items are created using info from a list called "devices" (device_handler.devices). when no block devices are detected, the list is empty, creating zero MenuItems, and causing the following ValueError: ValueError: Menu must have at least one item this change checks if the length of the list is shorter than 1 (empty list) before constructing the menu. if the list is empty, the user will be notified that no disks were detected. otherwise, the menu is created and behaves as normal * Fixed ruff formatting issue * Fixed ruff formatting issue --------- Co-authored-by: Anton Hvornum --- archinstall/lib/disk/disk_menu.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/archinstall/lib/disk/disk_menu.py b/archinstall/lib/disk/disk_menu.py index f8e8e2e3..f89635af 100644 --- a/archinstall/lib/disk/disk_menu.py +++ b/archinstall/lib/disk/disk_menu.py @@ -311,6 +311,10 @@ async def select_devices(preset: list[BDevice] | None = []) -> list[BDevice] | N devices = device_handler.devices + if len(devices) < 1: + await Notify(tr('No disks were detected. A disk is required to be able to install Arch Linux')).show() + return None + items = [ MenuItem( str(d.device_info.path),