From fc721cc94b2d2b68dc9b26ef6522a6dea8746cbb Mon Sep 17 00:00:00 2001 From: Softer Date: Tue, 28 Apr 2026 13:14:42 +0300 Subject: [PATCH] Address review feedback (#4485) - Drop is_nvidia_nouveau() helper. It is not called anywhere yet; can be re-added when a consumer lands. - Collapse the Sway+Nvidia confirmation result handling into a single expression now that allow_skip=False guarantees a boolean answer. --- archinstall/lib/hardware.py | 11 ----------- archinstall/lib/profile/profile_menu.py | 3 +-- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/archinstall/lib/hardware.py b/archinstall/lib/hardware.py index 6741295e..2cfdb706 100644 --- a/archinstall/lib/hardware.py +++ b/archinstall/lib/hardware.py @@ -81,17 +81,6 @@ class GfxDriver(Enum): case _: return False - def is_nvidia_nouveau(self) -> bool: - """ - True for the open-source nouveau driver (Mesa) for Nvidia GPUs. - Currently only NvidiaOpenSource. Officially supported by Sway. - """ - match self: - case GfxDriver.NvidiaOpenSource: - return True - case _: - return False - def packages_text(self) -> str: pkg_names = [p.value for p in self.gfx_packages()] text = tr('Installed packages') + ':\n' diff --git a/archinstall/lib/profile/profile_menu.py b/archinstall/lib/profile/profile_menu.py index 0e0d58fa..115c9fc0 100644 --- a/archinstall/lib/profile/profile_menu.py +++ b/archinstall/lib/profile/profile_menu.py @@ -105,8 +105,7 @@ class ProfileMenu(AbstractSubMenu[ProfileConfiguration]): preset=False, ).show() - if not result.get_value(): - return preset + return driver if result.get_value() else preset return driver