Commit Graph

1119 Commits

Author SHA1 Message Date
Anton Hvornum 500da432bf
Fixed an import of not yet loaded module 2022-03-28 16:42:09 +02:00
Anton Hvornum 66289c13d8
Fixed an import of not yet loaded module 2022-03-28 16:41:41 +02:00
Anton Hvornum 1bf6e20bde
moved GlobalMenu into lib/menu/global_menu.py instead 2022-03-28 16:41:03 +02:00
Anton Hvornum e873e30c39
Fixed an import of not yet loaded module 2022-03-28 16:13:26 +02:00
Anton Hvornum fe164a700c
Fixed an import of not yet loaded module 2022-03-28 16:08:05 +02:00
Anton Hvornum de80fdc153
Fixed an import of not yet loaded module 2022-03-28 16:04:24 +02:00
Anton Hvornum 6c71f42b47
Fixed an import of not yet loaded module 2022-03-28 16:01:55 +02:00
Anton Hvornum 5456920681
Added missing imports (#1046) 2022-03-28 15:04:14 +02:00
Anton Hvornum 77bfa10d53
Added error handling to fstab (#1045)
* Added error handling to fstab

* Checking the exit code for == 0
2022-03-28 14:43:33 +02:00
Daniel c92c448f29
Fix some mypy things (#1023)
Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-03-28 14:14:45 +02:00
Patrick Schneeweis c614b3ed55
Clarify prompt text when providing superusers. (#1044)
Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-03-28 14:00:34 +02:00
Werner Llácer 4b4473632d
Subvolume User Interface (#1032)
* Deflate the user interactions file

* Fix flake8

* GlobalMenu split from selection_menu.py

* Upgrades to ListManager:
Can now show an empty list if there is no null action.
More information to the user at the header

* Put only_hd.py  and swiss.py to use new config printing mechanism
Solved a couple of bugs at
ListManager adding a str and a DeferredTranslation
ManageUser was missing an self argument in _check ...

* Create list and menus to manage subvolumes in btrfs partitions
Needed to modify manage_new_and_existing_partitions
Added a new parameter filter to select_partition, to allow filtering there

* Update internationalization strings

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-03-28 13:55:15 +02:00
Daniel 3dc0d957e8
Deflate user interactions (#1019)
* Deflate the user interactions file

* Fix flake8

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-03-28 13:49:05 +02:00
Werner Llácer e85c9b6531
Issues with Network Management and user management in menu (#1036)
* A problem with default values treatment at superusers (and users) on the main menu

* Solving issues when changing the selection of nic, ask_to_configure_network failed in several places.
Solved, temporarily with the creation of __getitem__ and get methods at NetworkManager

* Accept old style definitions for nic

* flake8 complains

* log string corrected (issue 1039)

* Correct exit when no disk is selected and we don't wish to continue
2022-03-28 13:44:10 +02:00
Anton Hvornum ac0162aba7
Improved color coding a bit. Added 5 more color options (not usable outside of 256-bit enabled terminals) 2022-03-16 21:21:26 +01:00
Werner Llácer a6b1cab077
Additions to Listmgr et alia (#1028)
* Permit multiple default actions as a list

* Define headers for list at ListManager and Menu

* small corrections for default values

* Make subvolume info work.
The real marker that signifies that a mounted subvolume exist is the bracket notation nor the at sign
2022-03-10 09:42:03 +01:00
Eugênio Pacceli Reis da Fonseca f7aba1d31c
Adding sudoers.d file instead of appending to sudoers (#1025)
* Addresses issue #985: Add sudoers.d file instead of appending to sudoers

* Fixed comment

* Added string safety check for illegal chars before attempting to create a file.

* Fixing commentaries

* More fixes to the sudoers.d modification: adds an includedir to sudoers if sudoers.d did not exist previously, waits for python to close and release the new rule file before attempting to set its permissions to 440.

* Regex fix and better code formatting.
2022-03-07 09:15:14 +01:00
Daniel d9d59bee68
Fix #1018 (#1021)
* Fix #1018

* Fix flake8

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-03-03 13:54:43 +01:00
Werner Llácer 47a9fba94b
A couple of corrections for the user interface (#1017)
* Preview size is now an argument for GeneralMenu
Parameter missing in call to save_config

* Update selection_menu.py

Co-authored-by: Anton Hvornum <anton.feeds+github@gmail.com>
2022-03-01 12:36:58 +01:00
Werner Llácer 86d991f442
User Management via lists (#1008)
* Fix user/superuser config

* Fix flake8

* Remove timezone check since we have a default value now

* Remove unused

* add new widget ListManager

* flake8 complains

* Null_action appears now in the main list (to simplify additions to the list)
Formatted data are now at the from to the actions submenu

* Manage users thru a ListManagers

* Define a default action in the menu, potentially independent of a null_action
Both default and null actions don't have to be part of the element's action list
Some cleanup

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton.feeds@gmail.com>
Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-02-28 23:11:25 +01:00
Werner Llácer 76a6c37893
Solves issue 1013 (#1016) 2022-02-28 22:38:04 +01:00
Anton Hvornum 5cf3fbfb41
Only set presets if presets are given. We should probably fix tghis in selection_menu.py line 636. But this solves an issue with broken harddrive selection for now. 2022-02-28 17:10:28 +01:00
Daniel 35a19a616a
Menu option save config (#1009)
* Add new save config menu option

* Update

* Fixed issue with merging

* Fixed merge issue (I think)

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton.feeds@gmail.com>
2022-02-28 17:03:37 +01:00
Werner Llácer f07704529f
add new widget ListManager (#1005)
* add new widget ListManager

* flake8 complains

* Null_action appears now in the main list (to simplify additions to the list)
Formatted data are now at the from to the actions submenu

* Define a default action in the menu, potentially independent of a null_action
Both default and null actions don't have to be part of the element's action list
Some cleanup
2022-02-28 16:17:10 +01:00
Daniel 537b9cab03
Rework network config (#1001)
* Update network configuration

* Rework network configuration

* Update documentation

* Fix flake8

* Update

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton.feeds@gmail.com>
2022-02-28 15:57:57 +01:00
Daniel fa87d85708
Fix (some) mypy things (#996)
* Fix mypy things

* Fix flake8

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-02-28 15:45:08 +01:00
Daniel 0fed839110
Rework the user/superuser configuration (#993)
* Fix user/superuser config

* Fix flake8

* Remove timezone check since we have a default value now

* Remove unused

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton.feeds@gmail.com>
2022-02-28 15:42:49 +01:00
komeil Parseh 7e19bf6e2e
Add password strength check (#983)
* Add password strength check

* Delete time.sleep and log, use the select class instead

* Ignore W503 in flake8

* Solve some problems of the password strength check algorithm

Part of the code was written by @phisch. This code tries to measure the strength of the user's password and suggests that the password is weak.

* rename function

* Restore the flake8 configuration file to its previous state
2022-02-28 15:33:09 +01:00
Werner Llácer f06aabb4d4
enhacements to the menu infraestructure (#978)
* Correct definition of btrfs standard layout

* Solve issue #936

* make ask_for_a_timezone as synonym to ask_timezone

* Some refining in GeneralMenu
secret is now a general function

* Revert "Some refining in GeneralMenu"

This reverts commit e6e131cb19.

* Activate load of preset values in GeneralMenu
Changed all select_functions definitions to the need of passing the preset value
Corrected problems at ask_to_configure_network, and management of preset values added

* minor glitches in menu processing, plus flake8 complains

* Changes to ask_to_configure_network following  @svartkanin code

* select_language adapted to preset value.
changes to the infraestructure to solve bugs

* functions adapted for preset values
* select_mirror_regions
* select_locale_lang
* select_locale_enc
* ask_for_swap

* Updated to preset values
* ask_for_bootloader
Won't use it
* set_root_password()

* Updated to preset values
* ask_for_audio_selection
* select_kernel
* ask_for_a_timezone

* Updated to use preset values
* select_ntp
* ask_ntp
* ask_for_swap
flake8 complains

* Adapted to preset values
* ask_additional_packages_to_install (from svartkanin)
* ask_to_configure_network (adapted from svartkanin version)

* Updated to preset values
* ask_hostname
* select_additional_repositories

* bug in nic conversion
_select_harddrives adapted to preset_menu
2022-02-28 15:02:39 +01:00
Daniel 391699497d
Fix #1006 (#1007)
Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-02-27 07:41:15 +01:00
Werner Llácer 6a0e3d9e4b
Issue992 (#1004)
* Solves issue 992

* flake8 complains

Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-02-23 08:41:03 +01:00
Daniel 4b3b21ed75
Check if pacman is available (#958)
* Check if pacman is available

* Update pacman call

* Added a graceful wait to `run_pacman`

* Fix flake8

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton.feeds+github@gmail.com>
2022-02-18 11:33:28 +01:00
Daniel 6489a417aa
Fix #966 - DeferredTranslation errors (#976)
* Fix #966

* Add types to parameters

* Update network configuration

* Backwards compability for nic config

* Update

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-02-15 08:44:58 +01:00
Dylan M. Taylor d9118a33b3
Switch from flags to an 'additional repository' menu (#977)
* Add multilib flag to enable this repository and enable multi-lib testing if testing flag is also passed

* Fix comments

* Attempt to force pacman to use the config file from the host

* Make sure the pacman configuration is copied to target

* flake8

* Call enable on additional-repositories

* Add method to select additional repositories

* Add menu option for additional repos

* This is a bit cleaner than having it all on one line

* Add import

* Use [] as default instead of None

* Use empty array for default option here

* Try this to ensure a valid array is returned on skipping

* Add additional-repositories to schema

* Missed changing this comment earlier
2022-02-13 16:30:49 +01:00
Dylan M. Taylor 67b922002a
Set the default timezone to UTC in the menu (#981)
It's already the default, this just keeps the user from needing to make the selection
2022-02-13 10:12:49 +01:00
Dylan M. Taylor 30e518f324
Use archlinux as the default hostname (#979) 2022-02-13 10:12:38 +01:00
Dylan M. Taylor fb72cc4204
Add multilib flag and enable multilib-testing if testing flag is also passed (#975)
* Add multilib flag to enable this repository and enable multi-lib testing if testing flag is also passed

* Fix comments

* Attempt to force pacman to use the config file from the host

* Make sure the pacman configuration is copied to target

* flake8
2022-02-13 10:10:35 +01:00
Dylan M. Taylor 8457aa5660
Set default bootloader based on presence of UEFI (#980)
* Set default bootloader based on presence of UEFI

* Correct a comment
2022-02-13 10:09:05 +01:00
Dylan M. Taylor a741b1a530
Don't enable multilib-testing unless we want multilib enabled. (#974)
* Don't enable multilib-testing unless we want multilib enabled.

* flake8

* Rename variable to make code more clear
2022-02-12 23:42:48 +01:00
Dylan M. Taylor 1df17eb987
Add a flag to install testing repositories (#967)
* Add a boolean to install testing repos, default to false

* More work on adding structure

* Add logic to enable testing repos.

* Corrections

* Make flake8 happy about regex escapes

* Flake8 doesn't like whitespace around equals

* Fix trailing whitespace character
2022-02-12 18:11:34 +01:00
Daniel 003a35be3d
Fix errors on selection of additional packages (#959)
* Fix errors on selection of additional packages

* Fix flake8

* Added the new /groups/search/json/?name=x endpoint merged today

* Fixed flake8 complaint

* Forgot to do json.loads() on the HTTP request result

* Update package selection

* Fix flake8

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-02-12 11:47:51 +01:00
Anton Hvornum 49a93480a8
Added better error output (based on #963) 2022-02-11 20:26:33 +01:00
Werner Llácer 5990491292
Some refinements to the Menu infraestructure (#962)
* Correct definition of btrfs standard layout

* Solve issue #936

* make ask_for_a_timezone as synonym to ask_timezone

* Some refining in GeneralMenu
secret is now a general function

* Revert "Some refining in GeneralMenu"

This reverts commit e6e131cb19.

* New version of the FlexibleMenu
* Added new functionality to Selector
* Created a GeneralMenu class
* GlobalMenu is made a child of GeneralMenu

* Some refining in GeneralMenu
secret is now a general function

* log is invoked in GeneralMenu directly

* Materialize again _setup_selection_menu_options. Gives more room to play

* Callbacks converted as methods
Synch() (data area and menu) decoupled from enable()
and made general before any run

* Only_hd gets a new implementation of the menu
flake8 corrections

* New version of the FlexibleMenu
* Added new functionality to Selector
* Created a GeneralMenu class
* GlobalMenu is made a child of GeneralMenu

* changes from the rebase left dangling

* Adapt to PR #874

* Adapted to nationalization framework (PR 893).
String still NOT adapted

* flake8 complains

* Use of archinstall.output_config instead of local copy at swiss.py

* Problems with the last merge

* git complains

* Menu admits now preset values and cursor positioning

* Now GeneralMenu moves to the next entry after each selection

* flake8 complains

* Control of limits for cursor position at GeneralMenu

* Make auto cursor positioning optional at GeneralMenu.
True for GlobalMenu

* Code cleanup after rebase, and flake8 complains
2022-02-11 13:22:35 +01:00
Anton Hvornum d3b6832345
Change usage `lsblk` to `blkid` where possible. And general improvements to disk handling. (#949)
* Renamed all_disks() to all_blockdevices() as it's technically a bit more correct. As it would return partitions as well. And it now distinguishes between BlockDevice() and Partition() when returning values. Also lsblk has been replaced with blkid and glob.glob() on /sys/class/block/

* Added handling of loop devices

* Added device information enrichment

* Removed old code

* Updated the usage of blockdevice.info['type'] to 'DEVTYPE' as per returned by blkid instead of lsblk

* Created a MapperDev() and DMCryptDev() 'disk' classes. This should help differentiate between BlockDevice(), Partition() and crypt-specific devices. Due to some new helper functions (mentioned later) BlockDevice().device_or_backfile has been simplified thanks to the information being pre-existing instead of having to call losetup. BlockDevice().mountpoint has been added as a dummy function. archinstall.enrich_blockdevice_information() has been added to enrich information extracted from blkid. archinstall.uevent() has been created to parse blkdid data when in -o export format, also eats up /sys/class/x/y/uevent data which is of the same format. all_blockdevices() now returns mapper devices found under /dev/mapper/ and properly returns the different types, not just BlockDevice() for everything. archinstall.get_parent_of_partition() has been added, which can translate /dev/sda1 to /dev/sda via strings by using /sys/class/block/ - note here tho that it has to be a blockdevice. Other parents won't return properly. archinstall.find_mountpoint() was created to be able to find mountpoints for a device, rather than the other way around which get_mount_info() handles. find_mountpoint() will convert /dev/sda1 -> /boot for instance, whereas get_mount_info('/boot') will convert /boot -> /dev/sda1. archinstall.get_partitions_in_use() will now properly traverse the entire structure, not just one level deep. This called for the creation of get_all_targets() which will take a dictionary structure and look for 'target': '/path' and return all '/path' values, recursively without being trapped in get_partitions_in_use() which has recursive targets. get_partitions_in_use() now returns a dictionary instead of a list, as it also returns the mountpoint and associated device. It will also prioritize MapperDev over DMCryptDev (as MapperDev is a child of DMCryptDev and can be resolved, other way around is 'trickier').

* Reverted Installer().partitions to return only the partitions. It's a slight speed defecit by not returning the mountpoints directly as {mntpoint: partition}, because the partition.mountpoint is a bit slow. But it avoids breaking legacy code :)

* Fixed a few imports, and added MapperDev.filesystem

* Fixed so that Installer().detect_encryption() uses the new separated logic of MapperDev/DMCryptDev/Partition

* Fixing a translation issue on hostname

* Added DMCryptDev.filesystem

* Added back archinstall.all_disks() for legacy reasons.

* Added a deprecation warning to archinstall.all_disks()

* Added a enrichment check for dm-crypt specific devices, which in turn sets DMCRYPT_NAME on the device information, making it easier to detect and target DMCryptDev when needed. This should avoid issues with loopdevices being detected as DMCryptDev. Also some minor tweaks to variable names on unencrypted setups

* Made debug output hidden without --verbose. Also added get_subvolume_info() which takes a path and returns any 'btrfs subvol show' information on the path

* Partition().subvolumes has been added. Which generates an iterator over potential subvolumes based on mountpoint. Partition().mount_information is now a list of mount-destinations, as one partition should be allowed to be mounted to several places (more commonly used in btrfs subvolumes). BtrfsSubvolume() has been added as a 'device type', which should make it more easy to recognize a BtrfsSubvolume object right out of the gate. Only found from Partition().subvolumes currently.

* Parameter fix for --verbose in log()

* Made sure loopdev devices have a PATH key as well, to make dealing with them as blockdevice as seamless as possible.

* Added backup information grabbing on uninitated devices

* Tweaked backup option if losetup cannot find the blockdev

* looks like losetup doesn't exit with a bad code even when it should. Raising ourselves when information is empty.

* Fixed structure returned from get_blockdevice_uevent()

* Made sure that fallback to blkid and loopdev info returns a PTTYPE (Partition Table Type) that is None, since we can't locate it yet (empty drive). But it's not False either, which is what logic after is looking for

* Deprecated split_bind_name() and added more debugging

* get_partitions_in_use() now only iterates over Partition() objects. And properly checks all mountpoints, not only the first.

* Flipped SysCallError to show the last 500 bytes if data rather than the first, to catch the actual errors.

* Removed anonymous parameters to all_blockdevices()

* Added .mount_information to MapperDev

* Added typing annotations

* Partition().mountpoint is now a @property that will live-report the current mountpoint.

* Removed the need for setting Partition().mountpoint = X when calling .mount() and .unmount(), as it's live-reported instead.

* Added .subvolumes to MapperDev()

* Added debug information

* Muting F841 in helpers.py

* Tweaked debug information in get_mount_info()

* Minimized log output by moving Partition().mountpoint to DEBUG, as partitions are allowed to not be mounted

* Simplified Installer().add_bootloader() to act as a router to the new split function, one for each bootloader type. This since flake8 complained about complexity and I agree that it became to wild.
2022-02-08 23:21:20 +01:00
Anton Hvornum 1515fb9fde
Calling Partition().partprobe() instead of general partprobe. This avoids read-only issues and lets Partition().partprobe() deal with the error checks. 2022-02-07 09:10:39 +01:00
Werner Llácer ef558fdb45
Solving some issues after merging flexible_menu (#948)
* Correct definition of btrfs standard layout

* Solve issue #936

* make ask_for_a_timezone as synonym to ask_timezone

* first batch of changes due to the last merges
selector.text is a call to selector.menu_text
A number of Generalmenu methods reappeared in their old version at Global

* disk encryption password menu option restored
2022-02-07 01:58:33 +01:00
Werner Llácer 1ea6fea1d8
Flexible menu 2 (#916)
* Correct definition of btrfs standard layout

* New version of the FlexibleMenu
* Added new functionality to Selector
* Created a GeneralMenu class
* GlobalMenu is made a child of GeneralMenu

* Some refining in GeneralMenu
secret is now a general function

* log is invoked in GeneralMenu directly

* Correction at GeneralMenu

* Materialize again _setup_selection_menu_options. Gives more room to play

* Callbacks converted as methods
Synch() (data area and menu) decoupled from enable()
and made general before any run

* script swiss added to the patch set

* Only_hd gets a new implementation of the menu
flake8 corrections

* swiss.py description added

* New version of the FlexibleMenu
* Added new functionality to Selector
* Created a GeneralMenu class
* GlobalMenu is made a child of GeneralMenu

* changes from the rebase left dangling

* Modify order of execution between exec_menu and post_processing.
Added selector_name as parameter for exec_menu

* minor corrections to the scripts

* Adapt to PR #874

* Solve issue #936

* make ask_for_a_timezone as synonym to ask_timezone

* Adapted to nationalization framework (PR 893).
String still NOT adapted

* flake8 complains

* Use of archinstall.output_config instead of local copy at swiss.py

* Problems with the last merge

* more flake8 complains. caused by reverted changes re. ask*timezone

* git complains

Co-authored-by: Anton Hvornum <anton@hvornum.se>
2022-02-06 11:54:13 +01:00
Daniel 9fb8d3164c
Update nationalization (#944)
* Update nationalization

* Update translations

* Finish german translation

* Fix errors #943

* Add remaining translations

* Fix alignment in menu

* Update README

* Update translations:

* Fix flake8

* Update tz function

Co-authored-by: Daniel Girtler <girtler.daniel@gmail.com>
2022-02-06 11:30:26 +01:00
Werner Llácer ec73bdab4c
Routine to properly print and save config data (#888)
* Created a standard function to show/save the config parameters

* flake8 complains

* Correct definition of btrfs standard layout

* Solve issue #936

* Moved output_configs to lib/configuration.py
2022-02-05 13:52:14 +01:00
Anton Hvornum 0ec9549dc4
Renamed ask_timezone() 2022-02-05 11:17:41 +01:00