From acdcd91327f11ee933a551ed94e5d09c876e559c Mon Sep 17 00:00:00 2001 From: wheaney <42350981+wheaney@users.noreply.github.com> Date: Thu, 15 Jan 2026 15:02:55 -0800 Subject: [PATCH] Remove logging, fix slider ticks --- kwin/src/kcm/breezydesktopeffectkcm.cpp | 19 ------------------- kwin/src/kcm/breezydesktopeffectkcm.ui | 11 +++++------ 2 files changed, 5 insertions(+), 25 deletions(-) diff --git a/kwin/src/kcm/breezydesktopeffectkcm.cpp b/kwin/src/kcm/breezydesktopeffectkcm.cpp index 567fa54..39ea26c 100644 --- a/kwin/src/kcm/breezydesktopeffectkcm.cpp +++ b/kwin/src/kcm/breezydesktopeffectkcm.cpp @@ -778,18 +778,14 @@ QString BreezyDesktopEffectConfig::measurementUnitsFromUi() const void BreezyDesktopEffectConfig::applyDistanceLabelFormatters() { - qCCritical(KWIN_XR) << "applyDistanceLabelFormatters()"; - auto *focused = ui.kcfg_FocusedDisplayDistance; auto *all = ui.kcfg_AllDisplaysDistance; if (!focused || !all) { - qCCritical(KWIN_XR) << "applyDistanceLabelFormatters: missing sliders" << focused << all; return; } // Only apply the unit conversion labels when the driver reports positional tracking. if (!m_connectedDevicePoseHasPosition) { - qCCritical(KWIN_XR) << "applyDistanceLabelFormatters: pose has no position -> clearing formatter"; focused->clearValueToDisplayStringFn(); all->clearValueToDisplayStringFn(); focused->setValueUnitsSuffix(QString()); @@ -801,33 +797,18 @@ void BreezyDesktopEffectConfig::applyDistanceLabelFormatters() const QString units = measurementUnitsFromUi(); const QLocale loc; - qCCritical(KWIN_XR) << "applyDistanceLabelFormatters: installing formatter" - << "fullDistanceCm=" << fullCm - << "units=" << units; - // Units should appear only in the floating value bubble, not on tick labels. focused->setValueUnitsSuffix(units); all->setValueUnitsSuffix(units); LabeledSlider::ValueToDisplayStringFn fn = [fullCm, units, loc](int raw) -> QString { - static int s_calls = 0; - if (s_calls < 25) { - qCCritical(KWIN_XR) << "distance label formatter called" << "raw=" << raw << "units=" << units << "fullCm=" << fullCm; - ++s_calls; - } if (fullCm <= 0.0) return QString(); const double ratio = static_cast(raw) / 100.0; // slider uses a 2-decimal fixed-point scale const double cm = ratio * fullCm; if (units == QLatin1String("in")) { const double inches = cm / 2.54; - if (s_calls <= 25) { - qCCritical(KWIN_XR) << "distance formatter computed" << ratio << "->" << inches << "in"; - } return loc.toString(inches, 'f', 1); } - if (s_calls <= 25) { - qCCritical(KWIN_XR) << "distance formatter computed" << ratio << "->" << cm << "cm"; - } return loc.toString(cm, 'f', 0); }; diff --git a/kwin/src/kcm/breezydesktopeffectkcm.ui b/kwin/src/kcm/breezydesktopeffectkcm.ui index 815d884..373c896 100644 --- a/kwin/src/kcm/breezydesktopeffectkcm.ui +++ b/kwin/src/kcm/breezydesktopeffectkcm.ui @@ -108,10 +108,10 @@ QSlider::NoTicks - 5 + 25 - 25 + 50 Qt::Horizontal @@ -137,10 +137,10 @@ QSlider::NoTicks - 5 + 25 - 25 + 50 Qt::Horizontal @@ -642,8 +642,7 @@ - - +