From 90de5ca6adcf6874d6f6a4598a0b3de54af90743 Mon Sep 17 00:00:00 2001
From: AbronStudio <teamabron@gmail.com>
Date: Sat, 9 Aug 2025 11:10:48 +0330
Subject: [PATCH] Refactor: Improve error handling and UI in
 DiscoverServersList

This commit enhances the error handling and user interface in `DiscoverServersList.kt`.

- Improved loading indicator alignment by centering it within a `Box` that takes up available space.
- Added a retry mechanism for scenarios where loading servers fails or no servers are found. This includes:
    - Displaying an error message.
    - Providing a "Retry" button (`SquareButton`) that triggers `viewModel::loadServers` on click.
    - Centering the error message and retry button within the screen.
---
 .../chat/discover/DiscoverServersList.kt      | 39 ++++++++++++++-----
 1 file changed, 29 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/chat/revolt/composables/screens/chat/discover/DiscoverServersList.kt b/app/src/main/java/chat/revolt/composables/screens/chat/discover/DiscoverServersList.kt
index 7f0146ed..374d924a 100644
--- a/app/src/main/java/chat/revolt/composables/screens/chat/discover/DiscoverServersList.kt
+++ b/app/src/main/java/chat/revolt/composables/screens/chat/discover/DiscoverServersList.kt
@@ -3,6 +3,7 @@ package chat.revolt.composables.screens.chat.discover
 import androidx.compose.foundation.Image
 import androidx.compose.foundation.background
 import androidx.compose.foundation.clickable
+import androidx.compose.foundation.layout.Arrangement
 import androidx.compose.foundation.layout.Box
 import androidx.compose.foundation.layout.Column
 import androidx.compose.foundation.layout.Row
@@ -41,6 +42,7 @@ import androidx.hilt.navigation.compose.hiltViewModel
 import chat.revolt.R
 import chat.revolt.api.RevoltAPI
 import chat.revolt.api.routes.googlesheets.ServerData
+import chat.revolt.composables.generic.SquareButton
 
 @Composable
 fun DiscoverServersList(
@@ -96,19 +98,36 @@ fun DiscoverServersList(
 
         when {
             uiState.isLoading -> {
-                CircularProgressIndicator(
-                    modifier = Modifier
-                        .padding(16.dp)
-                        .align(Alignment.CenterHorizontally)
-                )
+                Box(
+                    modifier = Modifier.weight(1f),
+                    contentAlignment = Alignment.Center
+                ) {
+                    CircularProgressIndicator(
+                        modifier = Modifier
+                            .padding(16.dp)
+                    )
+                }
             }
 
-            uiState.error != null -> {
-                Text(stringResource(R.string.error))
-            }
+            uiState.error != null || uiState.servers.isEmpty() -> {
+               Box(
+                   Modifier.weight(1f)
+               ) {
+                   Column(
+                       modifier = Modifier.fillMaxSize(),
+                       horizontalAlignment = Alignment.CenterHorizontally,
+                       verticalArrangement = Arrangement.Center,
 
-            uiState.servers.isEmpty() -> {
-                Text(stringResource(R.string.no_servers_found))
+                   ) {
+                       Text(stringResource(R.string.error))
+                       Spacer(Modifier.height(8.dp))
+                       SquareButton(
+                           onClick = viewModel::loadServers
+                       ) {
+                           Text(stringResource(R.string.retry))
+                       }
+                   }
+               }
             }
 
             else -> {