RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 3c64fbf405 into a3259400a3

This commit is contained in:
Brandon Pugsley 2026-07-14 19:16:59 -07:00 committed by GitHub
parent a3259400a3 3c64fbf405
commit 027f84d590
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 42 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
gstack-upgrade/migrations/v1.27.0.0.sh
View File

@ -184,19 +184,42 @@ if ! journal_done "gh_repo_renamed"; then
case "$HOST" in case "$HOST" in
github) github)
if command -v gh >/dev/null 2>&1 && gh auth status >/dev/null 2>&1; then if command -v gh >/dev/null 2>&1 && gh auth status >/dev/null 2>&1; then
# Idempotent: if new name already exists, treat as success. # `gh repo rename --repo` and `gh repo edit` both require the
if gh repo view "$NEW_REPO_NAME" >/dev/null 2>&1; then # "[HOST/]OWNER/REPO" form. Passing a bare repo name (as earlier
echo " repo already named $NEW_REPO_NAME on GitHub — no-op" >&2 # versions of this migration did) fails with:
# expected the "[HOST/]OWNER/REPO" format, got "<name>"
# Resolve the authenticated user's login and qualify both names.
GH_OWNER=$(gh api user --jq .login 2>/dev/null || echo "")
if [ -z "$GH_OWNER" ]; then
echo " WARNING: could not resolve gh authenticated user — skipping rename" >&2
echo " manual: gh repo rename $NEW_REPO_NAME --repo <owner>/$OLD_REPO_NAME --yes" >&2
mark_done "gh_repo_renamed" mark_done "gh_repo_renamed"
else else
if gh repo rename "$NEW_REPO_NAME" --repo "$OLD_REPO_NAME" --yes 2>/dev/null \ OLD_QUALIFIED="${GH_OWNER}/${OLD_REPO_NAME}"
|| gh repo edit "$OLD_REPO_NAME" --name "$NEW_REPO_NAME" 2>/dev/null; then NEW_QUALIFIED="${GH_OWNER}/${NEW_REPO_NAME}"
echo " renamed on GitHub" >&2 # Idempotent: if new name already exists, treat as success.
if gh repo view "$NEW_QUALIFIED" >/dev/null 2>&1; then
echo " repo already named $NEW_REPO_NAME on GitHub — no-op" >&2
mark_done "gh_repo_renamed" mark_done "gh_repo_renamed"
else else
echo " WARNING: gh rename failed (repo may not exist or permission denied)" >&2 RENAME_ERR=""
echo " skipping step 1; subsequent steps still run" >&2 RENAME_ERR2=""
mark_done "gh_repo_renamed" RENAME_OK=0
if RENAME_ERR=$(gh repo rename "$NEW_REPO_NAME" --repo "$OLD_QUALIFIED" --yes 2>&1); then
RENAME_OK=1
elif RENAME_ERR2=$(gh repo edit "$OLD_QUALIFIED" --name "$NEW_REPO_NAME" 2>&1); then
RENAME_OK=1
fi
if [ "$RENAME_OK" = "1" ]; then
echo " renamed on GitHub" >&2
mark_done "gh_repo_renamed"
else
echo " WARNING: gh rename failed for $OLD_QUALIFIED" >&2
[ -n "$RENAME_ERR" ] && echo " gh repo rename: $RENAME_ERR" >&2
[ -n "$RENAME_ERR2" ] && echo " gh repo edit: $RENAME_ERR2" >&2
echo " skipping step 1; subsequent steps still run" >&2
mark_done "gh_repo_renamed"
fi
fi fi
fi fi
else else

11
test/migrations-v1.27.0.0.test.ts
View File

@ -27,11 +27,20 @@ function makeFakeGh(opts: { authStatus?: 'ok' | 'fail'; renameSucceeds?: boolean
echo "gh $@" >> "${callLog}" echo "gh $@" >> "${callLog}"
case "$1" in case "$1" in
auth) ${authStatus === 'ok' ? 'exit 0' : 'exit 1'} ;; auth) ${authStatus === 'ok' ? 'exit 0' : 'exit 1'} ;;
api)
# gh api user --jq .login → print authenticated login
shift
if [ "\${1:-}" = "user" ]; then
echo "testuser"
exit 0
fi
exit 0
;;
repo) repo)
shift shift
case "$1" in case "$1" in
view) view)
# gh repo view <name> # gh repo view <owner/name> | <name>
shift shift
${alreadyRenamed ? `if echo "$@" | grep -q gstack-artifacts; then exit 0; else exit 1; fi` : `exit 1`} ${alreadyRenamed ? `if echo "$@" | grep -q gstack-artifacts; then exit 0; else exit 1; fi` : `exit 1`}
;; ;;