From 12ff4d40eb3b3b1dd2a02444e9df0c4e3a4cc66f Mon Sep 17 00:00:00 2001 From: mant1st Date: Sun, 5 Jul 2026 16:02:07 +1000 Subject: [PATCH] fix: bound ship unverifiable confirmation loop --- ship/sections/plan-completion.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ship/sections/plan-completion.md b/ship/sections/plan-completion.md index b325d7a10..8850723fe 100644 --- a/ship/sections/plan-completion.md +++ b/ship/sections/plan-completion.md @@ -152,7 +152,9 @@ After producing the completion checklist, evaluate in priority order: **Per-item confirmation is mandatory.** Do NOT use a single AskUserQuestion to blanket-confirm all UNVERIFIABLE items. Blanket confirmation is the failure mode that surfaced in VAS-449 (user clicks A without opening any file). Instead: - - Loop through UNVERIFIABLE items one at a time. + - Maximum iterations: `min(number_of_UNVERIFIABLE_items, 5)`. + - Process each UNVERIFIABLE item exactly once, one at a time. + - Stop immediately on any `N`, unavailable user/tool response, or malformed answer, and resume only when the user explicitly re-runs `/ship` after fixing the missing work. - For each item, use AskUserQuestion with the item's *specific* manual check (e.g., "Confirm: does `~/Development/domain-hq/docs/dashboard.md` exist?", not "Have you checked all items?"). - Options per item: Y) Confirmed done — cite what you verified (free-text, embedded in PR body)