From 281349ff789fbf461752b0b0557a422041b96d02 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sat, 15 Aug 2026 08:50:02 -0700 Subject: [PATCH] =?UTF-8?q?test(evals):=20review-army=20fixture=20extracts?= =?UTF-8?q?=20sections=20=E2=80=94=201871=20->=20650=20lines?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CS1's set plus Step 1.5 (PLAN COMPLETION AUDIT machinery) and Step 4.5 (army dispatch, quality_score, findings schema) that the 7 army tests assert on. Pin test guards the three load-bearing strings. Co-Authored-By: Claude Fable 5 --- test/skill-e2e-review-army.test.ts | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test/skill-e2e-review-army.test.ts b/test/skill-e2e-review-army.test.ts index be08a721e..3a0a802b6 100644 --- a/test/skill-e2e-review-army.test.ts +++ b/test/skill-e2e-review-army.test.ts @@ -4,6 +4,7 @@ import { ROOT, runId, describeIfSelected, testConcurrentIfSelected, logCost, recordE2E, createEvalCollector, finalizeEvalCollector, } from './helpers/e2e-helpers'; +import { extractSkillSections, REVIEW_ARMY_E2E_SECTIONS } from './helpers/skill-fixture'; import { spawnSync } from 'child_process'; import * as fs from 'fs'; import * as path from 'path'; @@ -22,9 +23,15 @@ function setupRepo(prefix: string): { dir: string; run: (cmd: string, args: stri return { dir, run }; } -// Helper: copy review skill files to test dir +// Helper: stage review skill files in the test dir. The SKILL.md fixture is +// EXTRACTED (CLAUDE.md: "E2E test fixtures: extract, don't copy") — core +// review workflow + Step 1.5 (Plan Completion Audit) + Step 4.5 (Review Army +// dispatch: quality score, JSON schema, consensus, Red Team). function copyReviewFiles(dir: string) { - fs.copyFileSync(path.join(ROOT, 'review', 'SKILL.md'), path.join(dir, 'review-SKILL.md')); + fs.writeFileSync( + path.join(dir, 'review-SKILL.md'), + extractSkillSections(path.join(ROOT, 'review'), REVIEW_ARMY_E2E_SECTIONS), + ); fs.copyFileSync(path.join(ROOT, 'review', 'checklist.md'), path.join(dir, 'review-checklist.md')); fs.copyFileSync(path.join(ROOT, 'review', 'greptile-triage.md'), path.join(dir, 'review-greptile-triage.md')); // Copy specialist checklists