RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(setup): skip Playwright install if already in custom browsers path

This commit is contained in:
Huang 2026-06-04 13:48:04 +08:00
parent 3274336241
commit 2aff99f4c2
2 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -38,3 +38,4 @@ supabase/.temp/
# Throughput analysis — local-only, regenerate via scripts/garry-output-comparison.ts # Throughput analysis — local-only, regenerate via scripts/garry-output-comparison.ts
docs/throughput-*.json docs/throughput-*.json
.playwright-browsers

24
setup
View File

@ -18,6 +18,11 @@ INSTALL_GSTACK_DIR="$(cd "$(dirname "$0")" && pwd)"
SOURCE_GSTACK_DIR="$(cd "$(dirname "$0")" && pwd -P)" SOURCE_GSTACK_DIR="$(cd "$(dirname "$0")" && pwd -P)"
INSTALL_SKILLS_DIR="$(dirname "$INSTALL_GSTACK_DIR")" INSTALL_SKILLS_DIR="$(dirname "$INSTALL_GSTACK_DIR")"
BROWSE_BIN="$SOURCE_GSTACK_DIR/browse/dist/browse" BROWSE_BIN="$SOURCE_GSTACK_DIR/browse/dist/browse"
# Use custom Playwright browsers path if manually installed (avoids macOS cache permission issues)
if [ -d "$SOURCE_GSTACK_DIR/.playwright-browsers" ]; then
export PLAYWRIGHT_BROWSERS_PATH="$SOURCE_GSTACK_DIR/.playwright-browsers"
fi
CODEX_SKILLS="$HOME/.codex/skills" CODEX_SKILLS="$HOME/.codex/skills"
CODEX_GSTACK="$CODEX_SKILLS/gstack" CODEX_GSTACK="$CODEX_SKILLS/gstack"
FACTORY_SKILLS="$HOME/.factory/skills" FACTORY_SKILLS="$HOME/.factory/skills"
@ -261,12 +266,12 @@ ensure_playwright_browser() {
# (oven-sh/bun#4253). Use Node.js to verify Chromium works instead. # (oven-sh/bun#4253). Use Node.js to verify Chromium works instead.
( (
cd "$SOURCE_GSTACK_DIR" cd "$SOURCE_GSTACK_DIR"
node -e "const { chromium } = require('playwright'); (async () => { const b = await chromium.launch(); await b.close(); })()" 2>/dev/null node -e "const { chromium } = require('playwright'); (async () => { const b = await chromium.launch({ channel: 'chromium' }); await b.close(); })()" 2>/dev/null
) )
else else
( (
cd "$SOURCE_GSTACK_DIR" cd "$SOURCE_GSTACK_DIR"
bun --eval 'import { chromium } from "playwright"; const browser = await chromium.launch(); await browser.close();' bun --eval 'import { chromium } from "playwright"; const browser = await chromium.launch({ channel: "chromium" }); await browser.close();'
) >/dev/null 2>&1 ) >/dev/null 2>&1
fi fi
} }
@ -483,11 +488,16 @@ fi
# 2. Ensure Playwright's Chromium is available # 2. Ensure Playwright's Chromium is available
if ! ensure_playwright_browser; then if ! ensure_playwright_browser; then
echo "Installing Playwright Chromium..." # Skip download if browser already exists in custom path (avoids macOS cache hang)
( if [ -n "${PLAYWRIGHT_BROWSERS_PATH:-}" ] && [ -d "$PLAYWRIGHT_BROWSERS_PATH/chromium-1208" ]; then
cd "$SOURCE_GSTACK_DIR" echo "Playwright Chromium already installed at $PLAYWRIGHT_BROWSERS_PATH"
bunx playwright install chromium else
) echo "Installing Playwright Chromium..."
(
cd "$SOURCE_GSTACK_DIR"
bunx playwright install chromium
)
fi
if [ "$IS_WINDOWS" -eq 1 ]; then if [ "$IS_WINDOWS" -eq 1 ]; then
# On Windows, Node.js launches Chromium (not Bun — see oven-sh/bun#4253). # On Windows, Node.js launches Chromium (not Bun — see oven-sh/bun#4253).