RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge 20ae32aec5 into a3259400a3

This commit is contained in:
Tim Linnet 2026-07-14 19:16:50 -07:00 committed by GitHub
parent a3259400a3 20ae32aec5
commit 3a6013f691
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plan-eng-review/sections/review-sections.md
View File

@ -126,6 +126,7 @@ Evaluate:
* Code organization and module structure. * Code organization and module structure.
* DRY violations—be aggressive here. * DRY violations—be aggressive here.
* Error handling patterns and missing edge cases (call these out explicitly). * Error handling patterns and missing edge cases (call these out explicitly).
* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast.
* Technical debt hotspots. * Technical debt hotspots.
* Areas that are over-engineered or under-engineered relative to my preferences. * Areas that are over-engineered or under-engineered relative to my preferences.
* Existing ASCII diagrams in touched files — are they still accurate after this change? * Existing ASCII diagrams in touched files — are they still accurate after this change?

1
plan-eng-review/sections/review-sections.md.tmpl
View File

@ -28,6 +28,7 @@ Evaluate:
* Code organization and module structure. * Code organization and module structure.
* DRY violations—be aggressive here. * DRY violations—be aggressive here.
* Error handling patterns and missing edge cases (call these out explicitly). * Error handling patterns and missing edge cases (call these out explicitly).
* Server-gated or actuated actions with optimistic UI—does the client await and surface the real result, or assume success? A swallowed rejection (auth/permission/validation) renders as false success; verify the effect landed, not the toast.
* Technical debt hotspots. * Technical debt hotspots.
* Areas that are over-engineered or under-engineered relative to my preferences. * Areas that are over-engineered or under-engineered relative to my preferences.
* Existing ASCII diagrams in touched files — are they still accurate after this change? * Existing ASCII diagrams in touched files — are they still accurate after this change?