From 420b2f730d7744d2a47797ca6e57175f2682bf36 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 14 Aug 2026 18:53:28 -0700 Subject: [PATCH] test: include design/test/ in the free suite and the sharded runner MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit design/test was absent from both the package.json test globs and TEST_ROOTS in scripts/test-free-shards.ts — its tests (including one of the teardown bombs removed in the previous commit) never ran in any CI or local free run, so design fixes could ship without their unit tests executing. Co-Authored-By: Claude Fable 5 --- package.json | 2 +- scripts/test-free-shards.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index fd788bcb8..27fc7dad4 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "gen:skill-docs:user": "bun run scripts/gen-skill-docs.ts --respect-detection", "dev": "bun run browse/src/cli.ts", "server": "bun run browse/src/server.ts", - "test": "bun test browse/test/ test/ make-pdf/test/ --ignore 'test/skill-e2e-*.test.ts' --ignore test/skill-llm-eval.test.ts --ignore test/skill-routing-e2e.test.ts --ignore test/codex-e2e.test.ts --ignore test/gemini-e2e.test.ts && (bun run slop:diff 2>/dev/null || true)", + "test": "bun test browse/test/ test/ make-pdf/test/ design/test/ --ignore 'test/skill-e2e-*.test.ts' --ignore test/skill-llm-eval.test.ts --ignore test/skill-routing-e2e.test.ts --ignore test/codex-e2e.test.ts --ignore test/gemini-e2e.test.ts && (bun run slop:diff 2>/dev/null || true)", "test:free": "bun run scripts/test-free-shards.ts", "test:windows": "bun run scripts/test-free-shards.ts --windows-only", "test:evals": "EVALS=1 bun test --retry 2 --concurrent --max-concurrency ${EVALS_CONCURRENCY:-15} test/skill-llm-eval.test.ts test/skill-e2e-*.test.ts test/skill-routing-e2e.test.ts test/codex-e2e.test.ts test/gemini-e2e.test.ts", diff --git a/scripts/test-free-shards.ts b/scripts/test-free-shards.ts index d6412243a..11f10ef38 100755 --- a/scripts/test-free-shards.ts +++ b/scripts/test-free-shards.ts @@ -30,7 +30,10 @@ import { spawnSync } from 'child_process'; import { isPaidTestFile } from '../test/helpers/paid-test-set'; const ROOT = path.resolve(import.meta.dir, '..'); -const TEST_ROOTS = ['browse/test', 'test', 'make-pdf/test'] as const; +// design/test was silently absent from BOTH the package.json test script and +// this list — design tests (including a teardown bomb) never ran in any CI +// or local free run. Keep the two lists in sync. +const TEST_ROOTS = ['browse/test', 'test', 'make-pdf/test', 'design/test'] as const; const TEST_FILE_REGEX = /\.test\.(?:[cm]?[jt]s|tsx|jsx)$/; // POSIX-only patterns that indicate a test will fail on windows-latest no