RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(test): tighten put_page regression pin to CLI subcommand 

The test asserted no substring 'put_page' anywhere in the resolver,
but the BRAIN_WRITE_BACK resolver legitimately references the MCP op
`mcp__gbrain__put_page` as the fallback path for calibration takes
when gbrain v0.42+'s `takes_add` op isn't available. The check
conflated the deprecated `gbrain put_page` CLI subcommand (renamed in
v0.18+ to `gbrain put`) with the still-valid MCP op of the same name.

Narrow the assertion to `gbrain put_page` (with the space) so the
fallback prose stays legal while the CLI rename regression stays caught.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Garry Tan 2026-05-27 08:33:58 -07:00
parent 9299ad1ae4
commit 4ab0f137ea
No known key found for this signature in database
GPG Key ID: C1F69E85C74EFE1D
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
test/resolvers-gbrain-put-rewrite.test.ts
View File

@ -35,11 +35,18 @@ function listTrackedSkillMd(): string[] {
return out.split("\n").filter((line) => line.trim().length > 0); return out.split("\n").filter((line) => line.trim().length > 0);
} }
describe("scripts/resolvers/gbrain.ts — no put_page in emitted instructions (regression for #1346)", () => { describe("scripts/resolvers/gbrain.ts — no `gbrain put_page` CLI subcommand in emitted instructions (regression for #1346)", () => {
it("resolver source ships only `gbrain put` instructions, not the renamed `put_page`", () => { it("resolver source ships only `gbrain put` CLI instructions, not the renamed `gbrain put_page`", () => {
// We're guarding against the v0.18 CLI subcommand rename
// (`gbrain put_page <slug>` → `gbrain put <slug>`). The MCP op
// `mcp__gbrain__put_page` is a legitimately separate identifier (the
// MCP-layer write op, unrelated to the CLI rename) and may still
// appear in resolver output as a fallback reference for the
// calibration-take write-back path. So check the CLI subcommand
// shape specifically: `gbrain put_page` with a space.
const src = readFileSync(RESOLVER_PATH, "utf-8"); const src = readFileSync(RESOLVER_PATH, "utf-8");
const stripped = stripComments(src); const stripped = stripComments(src);
expect(stripped).not.toContain("put_page"); expect(stripped).not.toContain("gbrain put_page");
}); });
it("every tracked SKILL.md file is free of the renamed gbrain put_page subcommand", () => { it("every tracked SKILL.md file is free of the renamed gbrain put_page subcommand", () => {