fix(careful): skip false positives in text-output command segments

/careful hook was triggering on patterns inside git commit -m messages,
echo arguments, and other text-output commands — even though those strings
are not executed as destructive operations.

Split command on shell operators (&&, ||, ;) and skip segments that are
purely text-output commands (git commit -m, echo, printf, cat). Only
check the remaining executable segments for destructive patterns.

Fixes #1060.
This commit is contained in:
jacob-wang 2026-04-21 05:04:19 +08:00
parent e23ff280a1
commit 5dacc814b8
1 changed files with 32 additions and 0 deletions

View File

@ -22,6 +22,38 @@ if [ -z "$CMD" ]; then
exit 0
fi
# Split command on shell operators and filter out text-only segments.
# Segments that start with git commit, echo, cat, or printf produce text output,
# not destructive actions — skip their content to avoid false positives.
FILTERED_CMD=""
IFS_SAVE="$IFS"
IFS="$(printf '\n\t')"
for segment in $(printf '%s' "$CMD" | sed 's/&&/\n/g; s/||/\n/g; s/;/ /g'); do
trimmed=$(printf '%s' "$segment" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
# Skip segments that are purely text-output commands (their args may mention
# dangerous patterns without actually executing them)
case "$trimmed" in
git\ commit\ -m\ *|git\ commit\ --message\ *|echo\ *|printf\ *|cat\ <*)
continue
;;
*)
if [ -n "$FILTERED_CMD" ]; then
FILTERED_CMD="$FILTERED_CMD && "
fi
FILTERED_CMD="${FILTERED_CMD}${trimmed}"
;;
esac
done
IFS="$IFS_SAVE"
# Use filtered command for pattern checks; if all segments were filtered out, allow
if [ -z "$FILTERED_CMD" ]; then
echo '{}'
exit 0
fi
CMD="$FILTERED_CMD"
# Normalize: lowercase for case-insensitive SQL matching
CMD_LOWER=$(printf '%s' "$CMD" | tr '[:upper:]' '[:lower:]')