RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(ship): absolute bin path for gstack-next-version in landing-report/land-and-deploy/review 

The queue-aware version allocator was invoked as a bare relative path
`bun run bin/gstack-next-version` in landing-report, land-and-deploy, and
review. When these installed skills run from a user's project repo, that
relative path doesn't resolve (the util lives at the gstack install root),
so the call fails and the `|| echo '{"offline":true}'` fallback fires —
silently dropping queue-collision awareness and degrading to a local bump.

ship/SKILL.md was already fixed to use the absolute
`~/.claude/skills/gstack/bin/gstack-next-version`; this applies the same
prefix to the three skills that were missed, matching the convention used
by every other gstack bin call in these files. Non-Claude host variants
already rendered `$GSTACK_ROOT/bin/...` correctly and are unaffected.

Edited the .tmpl sources and regenerated; CI bin/ refs (version-gate.yml,
.gitlab-ci.yml) are intentionally left bare since they run from the gstack
repo root.
This commit is contained in:
William Voorhees 2026-05-31 11:53:31 -07:00
parent 3bef43bc5a
commit 6d643c534b
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
land-and-deploy/SKILL.md
View File

@ -1159,7 +1159,7 @@ BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:s
# We don't need the exact original level — we just need "a level" that passes to the util.
# If the minor digit advanced, call it minor; patch digit, patch; etc. If base > branch, skip (not ours to land).
# For simplicity: use "patch" as a conservative default; util handles collision-past regardless of input level.
QUEUE_JSON=$(bun run bin/gstack-next-version \
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump patch \
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')

2
land-and-deploy/SKILL.md.tmpl
View File

@ -341,7 +341,7 @@ BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:s
# We don't need the exact original level — we just need "a level" that passes to the util.
# If the minor digit advanced, call it minor; patch digit, patch; etc. If base > branch, skip (not ours to land).
# For simplicity: use "patch" as a conservative default; util handles collision-past regardless of input level.
QUEUE_JSON=$(bun run bin/gstack-next-version \
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump patch \
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')

2
landing-report/SKILL.md
View File

@ -781,7 +781,7 @@ they'd claim for micro/patch/minor/major. Cheap (same gh call cached by bun).
```bash
for LEVEL in micro patch minor major; do
bun run bin/gstack-next-version \
bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump "$LEVEL" \
--current-version "$BASE_VERSION" \

2
landing-report/SKILL.md.tmpl
View File

@ -67,7 +67,7 @@ they'd claim for micro/patch/minor/major. Cheap (same gh call cached by bun).
```bash
for LEVEL in micro patch minor major; do
bun run bin/gstack-next-version \
bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump "$LEVEL" \
--current-version "$BASE_VERSION" \

2
review/SKILL.md
View File

@ -1074,7 +1074,7 @@ Check whether this PR's claimed VERSION still points at a free slot in the queue
BRANCH_VERSION=$(git show HEAD:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
BASE_BRANCH=$(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)
BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
QUEUE_JSON=$(bun run bin/gstack-next-version \
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump patch \
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')

2
review/SKILL.md.tmpl
View File

@ -89,7 +89,7 @@ Check whether this PR's claimed VERSION still points at a free slot in the queue
BRANCH_VERSION=$(git show HEAD:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
BASE_BRANCH=$(gh pr view --json baseRefName -q .baseRefName 2>/dev/null || echo main)
BASE_VERSION=$(git show origin/$BASE_BRANCH:VERSION 2>/dev/null | tr -d '\r\n[:space:]' || echo "")
QUEUE_JSON=$(bun run bin/gstack-next-version \
QUEUE_JSON=$(bun run ~/.claude/skills/gstack/bin/gstack-next-version \
--base "$BASE_BRANCH" \
--bump patch \
--current-version "$BASE_VERSION" 2>/dev/null || echo '{"offline":true}')