From 715c8778ea93ffe6c70fc85760f84f8e694ced00 Mon Sep 17 00:00:00 2001 From: Stefan Andrei <89592870+sneakygriff@users.noreply.github.com> Date: Sun, 16 Aug 2026 07:51:48 +0300 Subject: [PATCH] =?UTF-8?q?fix(test):=20snapshot.test.ts=20=E2=80=94=20for?= =?UTF-8?q?ward=20the=20BrowserManager=20through=20the=20handleReadCommand?= =?UTF-8?q?=20bridge=20(same=20class=20as=20compare-board)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Upstream v1.64.1.0 changed handleReadCommand's signature to (command, args, session, bm), but this file's local bridge still called it with the old 3-arg shape, leaving bm undefined. read-commands.ts:186's now-unconditional JS-origin assertion then TypeErrors on bm.hasCookieImports(), which is exactly the bug already fixed in compare-board.test.ts (8a37d902). Co-Authored-By: Claude Fable 5 --- browse/test/snapshot.test.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/browse/test/snapshot.test.ts b/browse/test/snapshot.test.ts index d3c012eaf..0d175ce98 100644 --- a/browse/test/snapshot.test.ts +++ b/browse/test/snapshot.test.ts @@ -14,7 +14,10 @@ import { handleMetaCommand } from '../src/meta-commands'; import * as fs from 'fs'; const handleReadCommand = (cmd: string, args: string[], b: BrowserManager) => - _handleReadCommand(cmd, args, b.getActiveSession()); + // Regression: the bridge must forward `b` — read-commands' now-unconditional + // JS-origin assertion calls bm.hasCookieImports(); omitting it TypeErrors + // every read. + _handleReadCommand(cmd, args, b.getActiveSession(), b); const handleWriteCommand = (cmd: string, args: string[], b: BrowserManager) => _handleWriteCommand(cmd, args, b.getActiveSession(), b);