RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: hide the osascript raise spawn too; exclude comments from the spawn invariant

This commit is contained in:
Matt Van Horn 2026-06-04 07:36:13 -07:00
parent 4d30746a1b
commit 77ebc1489e
No known key found for this signature in database
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
browse/src/cli.ts
View File

@ -288,6 +288,7 @@ function raiseHeadedWindowMacOS(): void {
nodeSpawn('osascript', ['-e', 'tell application "Google Chrome for Testing" to activate'], { nodeSpawn('osascript', ['-e', 'tell application "Google Chrome for Testing" to activate'], {
stdio: 'ignore', stdio: 'ignore',
detached: true, detached: true,
windowsHide: true,
}).unref(); }).unref();
} catch { } catch {
// osascript missing or app not present — non-fatal // osascript missing or app not present — non-fatal

5
browse/test/cli-windows-hide.test.ts
View File

@ -74,7 +74,10 @@ describe('detached server spawns carry windowsHide (#1863 fold-in)', () => {
}); });
test('every detached spawn site in cli.ts carries windowsHide:true', () => { test('every detached spawn site in cli.ts carries windowsHide:true', () => {
const body = read(CLI); const body = read(CLI)
.split('\n')
.filter((line) => !line.trim().startsWith('//') && !line.trim().startsWith('*'))
.join('\n');
const detachedSpawns = body.match(/detached:\s*true/g)?.length ?? 0; const detachedSpawns = body.match(/detached:\s*true/g)?.length ?? 0;
const windowsHideFlags = body.match(/windowsHide:\s*true/g)?.length ?? 0; const windowsHideFlags = body.match(/windowsHide:\s*true/g)?.length ?? 0;
expect(windowsHideFlags).toBeGreaterThanOrEqual(detachedSpawns); expect(windowsHideFlags).toBeGreaterThanOrEqual(detachedSpawns);