From 78313b4573daa06fab2dc409bac87dc655d7d7d8 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Wed, 27 May 2026 08:34:21 -0700 Subject: [PATCH] feat(brain): wire SAVE_RESULTS for plan-design-review + plan-devex-review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Adds {{GBRAIN_SAVE_RESULTS}} placeholder to the two planning skills that were missing it, immediately before {{BRAIN_WRITE_BACK}} (mirrors plan-eng-review:324 + office-hours:650). The corresponding skillSaveMap entries (design-reviews/ + devex-reviews/) landed with the resolver compression in the prior commit. Regenerated SKILL.md reflects the new placeholder position. The default no-gbrain generation (CI canonical) still suppresses the block — zero diff in the rendered output for non-gbrain users. All five planning skills now write a retrievable review page to gbrain when gbrain is detected at setup time, instead of three of five. Co-Authored-By: Claude Opus 4.7 (1M context) --- plan-design-review/SKILL.md | 2 ++ plan-design-review/SKILL.md.tmpl | 2 ++ plan-devex-review/SKILL.md | 2 ++ plan-devex-review/SKILL.md.tmpl | 2 ++ 4 files changed, 8 insertions(+) diff --git a/plan-design-review/SKILL.md b/plan-design-review/SKILL.md index 66359bf63..b7b365d18 100644 --- a/plan-design-review/SKILL.md +++ b/plan-design-review/SKILL.md @@ -1905,6 +1905,8 @@ staleness detection: if those files are later deleted, the learning can be flagg **Only log genuine discoveries.** Don't log obvious things. Don't log things the user already knows. A good test: would this insight save time in a future session? If yes, log it. + + ## Brain Calibration Write-Back (Phase 2 / gated) When the skill makes a typed prediction worth tracking (scope decision, diff --git a/plan-design-review/SKILL.md.tmpl b/plan-design-review/SKILL.md.tmpl index 32246b1b5..1e9f30499 100644 --- a/plan-design-review/SKILL.md.tmpl +++ b/plan-design-review/SKILL.md.tmpl @@ -450,6 +450,8 @@ Substitute values from the Completion Summary: {{LEARNINGS_LOG}} +{{GBRAIN_SAVE_RESULTS}} + {{BRAIN_WRITE_BACK}} {{BRAIN_CACHE_REFRESH}} diff --git a/plan-devex-review/SKILL.md b/plan-devex-review/SKILL.md index 83cf7e91f..10ac1eca2 100644 --- a/plan-devex-review/SKILL.md +++ b/plan-devex-review/SKILL.md @@ -2085,6 +2085,8 @@ staleness detection: if those files are later deleted, the learning can be flagg **Only log genuine discoveries.** Don't log obvious things. Don't log things the user already knows. A good test: would this insight save time in a future session? If yes, log it. + + ## Brain Calibration Write-Back (Phase 2 / gated) When the skill makes a typed prediction worth tracking (scope decision, diff --git a/plan-devex-review/SKILL.md.tmpl b/plan-devex-review/SKILL.md.tmpl index 4bda52aac..3e52d40be 100644 --- a/plan-devex-review/SKILL.md.tmpl +++ b/plan-devex-review/SKILL.md.tmpl @@ -789,6 +789,8 @@ If any AskUserQuestion goes unanswered, note here. Never silently default. {{LEARNINGS_LOG}} +{{GBRAIN_SAVE_RESULTS}} + {{BRAIN_WRITE_BACK}} {{BRAIN_CACHE_REFRESH}}