RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

feat: review dashboard — eng required, CEO/design optional 

Only Eng Review gates shipping. CEO Review recommended for big product
changes, Design Review for UI work — both informational only. Adds
skip_eng_review global config to disable the gate entirely.
This commit is contained in:
Garry Tan 2026-03-17 10:21:24 -07:00
parent 934e609ce8
commit 789d673a10
No known key found for this signature in database
GPG Key ID: C1F69E85C74EFE1D
6 changed files with 86 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
plan-design-review/SKILL.md
View File

@ -576,11 +576,13 @@ Substitute values from the report:
## Review Readiness Dashboard ## Review Readiness Dashboard
After completing the review, read the review log to display the dashboard. After completing the review, read the review log and config to display the dashboard.
```bash ```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS" cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS"
echo "---CONFIG---"
~/.claude/skills/gstack/bin/gstack-config get skip_eng_review 2>/dev/null || echo "false"
``` ```
Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display: Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display:
@ -589,17 +591,23 @@ Parse the output. Find the most recent entry for each skill (plan-ceo-review, pl
+====================================================================+ +====================================================================+
| REVIEW READINESS DASHBOARD | | REVIEW READINESS DASHBOARD |
+====================================================================+ +====================================================================+
| Review | Runs | Last Run | Status | | Review | Runs | Last Run | Status | Required |
|-----------------|------|---------------------|----------------------| |-----------------|------|---------------------|-----------|----------|
| CEO Review | 1 | 2026-03-16 14:30 | CLEAR | | Eng Review | 1 | 2026-03-16 15:00 | CLEAR | YES |
| Eng Review | 1 | 2026-03-16 15:00 | CLEAR | | CEO Review | 0 | — | — | no |
| Design Review | 0 | — | NOT YET RUN | | Design Review | 0 | — | — | no |
+--------------------------------------------------------------------+ +--------------------------------------------------------------------+
| VERDICT: 2/3 CLEAR — Design Review not yet run | | VERDICT: CLEARED — Eng Review passed |
+====================================================================+ +====================================================================+
``` ```
**Review tiers:**
- **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \`gstack-config set skip_eng_review true\` (the "don't bother me" setting).
- **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
- **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
**Verdict logic:** **Verdict logic:**
- **CLEARED TO SHIP (3/3)**: All three have >= 1 entry within 7 days AND most recent status is "clean" - **CLEARED**: Eng Review has >= 1 entry within 7 days with status "clean" (or \`skip_eng_review\` is \`true\`)
- **N/3 CLEAR**: Show count and list which are missing, have open issues, or are stale (>7 days) - **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
- Informational only — does NOT block. - CEO and Design reviews are shown for context but never block shipping
- If \`skip_eng_review\` config is \`true\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED

28
plan-eng-review/SKILL.md
View File

@ -277,11 +277,13 @@ Substitute values from the Completion Summary:
## Review Readiness Dashboard ## Review Readiness Dashboard
After completing the review, read the review log to display the dashboard. After completing the review, read the review log and config to display the dashboard.
```bash ```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS" cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS"
echo "---CONFIG---"
~/.claude/skills/gstack/bin/gstack-config get skip_eng_review 2>/dev/null || echo "false"
``` ```
Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display: Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display:
@ -290,20 +292,26 @@ Parse the output. Find the most recent entry for each skill (plan-ceo-review, pl
+====================================================================+ +====================================================================+
| REVIEW READINESS DASHBOARD | | REVIEW READINESS DASHBOARD |
+====================================================================+ +====================================================================+
| Review | Runs | Last Run | Status | | Review | Runs | Last Run | Status | Required |
|-----------------|------|---------------------|----------------------| |-----------------|------|---------------------|-----------|----------|
| CEO Review | 1 | 2026-03-16 14:30 | CLEAR | | Eng Review | 1 | 2026-03-16 15:00 | CLEAR | YES |
| Eng Review | 1 | 2026-03-16 15:00 | CLEAR | | CEO Review | 0 | — | — | no |
| Design Review | 0 | — | NOT YET RUN | | Design Review | 0 | — | — | no |
+--------------------------------------------------------------------+ +--------------------------------------------------------------------+
| VERDICT: 2/3 CLEAR — Design Review not yet run | | VERDICT: CLEARED — Eng Review passed |
+====================================================================+ +====================================================================+
``` ```
**Review tiers:**
- **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \`gstack-config set skip_eng_review true\` (the "don't bother me" setting).
- **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
- **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
**Verdict logic:** **Verdict logic:**
- **CLEARED TO SHIP (3/3)**: All three have >= 1 entry within 7 days AND most recent status is "clean" - **CLEARED**: Eng Review has >= 1 entry within 7 days with status "clean" (or \`skip_eng_review\` is \`true\`)
- **N/3 CLEAR**: Show count and list which are missing, have open issues, or are stale (>7 days) - **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
- Informational only — does NOT block. - CEO and Design reviews are shown for context but never block shipping
- If \`skip_eng_review\` config is \`true\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED
## Unresolved decisions ## Unresolved decisions
If the user does not respond to an AskUserQuestion or interrupts to move on, note which decisions were left unresolved. At the end of the review, list these as "Unresolved decisions that may bite you later" — never silently default to an option. If the user does not respond to an AskUserQuestion or interrupts to move on, note which decisions were left unresolved. At the end of the review, list these as "Unresolved decisions that may bite you later" — never silently default to an option.

28
scripts/gen-skill-docs.ts
View File

@ -817,11 +817,13 @@ Tie everything to user goals and product objectives. Always suggest specific imp
function generateReviewDashboard(): string { function generateReviewDashboard(): string {
return `## Review Readiness Dashboard return `## Review Readiness Dashboard
After completing the review, read the review log to display the dashboard. After completing the review, read the review log and config to display the dashboard.
\`\`\`bash \`\`\`bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS" cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS"
echo "---CONFIG---"
~/.claude/skills/gstack/bin/gstack-config get skip_eng_review 2>/dev/null || echo "false"
\`\`\` \`\`\`
Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display: Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display:
@ -830,20 +832,26 @@ Parse the output. Find the most recent entry for each skill (plan-ceo-review, pl
+====================================================================+ +====================================================================+
| REVIEW READINESS DASHBOARD | | REVIEW READINESS DASHBOARD |
+====================================================================+ +====================================================================+
| Review | Runs | Last Run | Status | | Review | Runs | Last Run | Status | Required |
|-----------------|------|---------------------|----------------------| |-----------------|------|---------------------|-----------|----------|
| CEO Review | 1 | 2026-03-16 14:30 | CLEAR | | Eng Review | 1 | 2026-03-16 15:00 | CLEAR | YES |
| Eng Review | 1 | 2026-03-16 15:00 | CLEAR | | CEO Review | 0 | — | — | no |
| Design Review | 0 | — | NOT YET RUN | | Design Review | 0 | — | — | no |
+--------------------------------------------------------------------+ +--------------------------------------------------------------------+
| VERDICT: 2/3 CLEAR — Design Review not yet run | | VERDICT: CLEARED — Eng Review passed |
+====================================================================+ +====================================================================+
\`\`\` \`\`\`
**Review tiers:**
- **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \\\`gstack-config set skip_eng_review true\\\` (the "don't bother me" setting).
- **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
- **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
**Verdict logic:** **Verdict logic:**
- **CLEARED TO SHIP (3/3)**: All three have >= 1 entry within 7 days AND most recent status is "clean" - **CLEARED**: Eng Review has >= 1 entry within 7 days with status "clean" (or \\\`skip_eng_review\\\` is \\\`true\\\`)
- **N/3 CLEAR**: Show count and list which are missing, have open issues, or are stale (>7 days) - **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
- Informational only — does NOT block.`; - CEO and Design reviews are shown for context but never block shipping
- If \\\`skip_eng_review\\\` config is \\\`true\\\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED`;
} }
const RESOLVERS: Record<string, () => string> = { const RESOLVERS: Record<string, () => string> = {

39
ship/SKILL.md
View File

@ -136,11 +136,13 @@ You are running the `/ship` workflow. This is a **non-interactive, fully automat
## Review Readiness Dashboard ## Review Readiness Dashboard
After completing the review, read the review log to display the dashboard. After completing the review, read the review log and config to display the dashboard.
```bash ```bash
eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null) eval $(~/.claude/skills/gstack/bin/gstack-slug 2>/dev/null)
cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS" cat ~/.gstack/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_REVIEWS"
echo "---CONFIG---"
~/.claude/skills/gstack/bin/gstack-config get skip_eng_review 2>/dev/null || echo "false"
``` ```
Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display: Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review). Ignore entries with timestamps older than 7 days. Display:
@ -149,25 +151,32 @@ Parse the output. Find the most recent entry for each skill (plan-ceo-review, pl
+====================================================================+ +====================================================================+
| REVIEW READINESS DASHBOARD | | REVIEW READINESS DASHBOARD |
+====================================================================+ +====================================================================+
| Review | Runs | Last Run | Status | | Review | Runs | Last Run | Status | Required |
|-----------------|------|---------------------|----------------------| |-----------------|------|---------------------|-----------|----------|
| CEO Review | 1 | 2026-03-16 14:30 | CLEAR | | Eng Review | 1 | 2026-03-16 15:00 | CLEAR | YES |
| Eng Review | 1 | 2026-03-16 15:00 | CLEAR | | CEO Review | 0 | — | — | no |
| Design Review | 0 | — | NOT YET RUN | | Design Review | 0 | — | — | no |
+--------------------------------------------------------------------+ +--------------------------------------------------------------------+
| VERDICT: 2/3 CLEAR — Design Review not yet run | | VERDICT: CLEARED — Eng Review passed |
+====================================================================+ +====================================================================+
``` ```
**Verdict logic:** **Review tiers:**
- **CLEARED TO SHIP (3/3)**: All three have >= 1 entry within 7 days AND most recent status is "clean" - **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \`gstack-config set skip_eng_review true\` (the "don't bother me" setting).
- **N/3 CLEAR**: Show count and list which are missing, have open issues, or are stale (>7 days) - **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
- Informational only — does NOT block. - **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
If the verdict is NOT "CLEARED TO SHIP (3/3)", use AskUserQuestion: **Verdict logic:**
- Show which reviews are missing or have open issues - **CLEARED**: Eng Review has >= 1 entry within 7 days with status "clean" (or \`skip_eng_review\` is \`true\`)
- RECOMMENDATION: Choose B (run missing reviews first) unless the change is trivial - **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
- Options: A) Ship anyway B) Abort — run missing review(s) first C) Reviews not relevant for this change - CEO and Design reviews are shown for context but never block shipping
- If \`skip_eng_review\` config is \`true\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED
If the verdict is NOT "CLEARED", use AskUserQuestion:
- Show that Eng Review is missing or has open issues
- RECOMMENDATION: Choose B (run eng review first) unless the change is obviously trivial (<20 lines, typo fix, config-only)
- Options: A) Ship anyway B) Abort — run /plan-eng-review first C) Change is too small to need eng review
- If CEO/Design reviews are missing, mention them as informational ("CEO Review not run — recommended for product changes") but do NOT block or recommend aborting for them
--- ---

9
ship/SKILL.md.tmpl
View File

@ -54,10 +54,11 @@ You are running the `/ship` workflow. This is a **non-interactive, fully automat
{{REVIEW_DASHBOARD}} {{REVIEW_DASHBOARD}}
If the verdict is NOT "CLEARED TO SHIP (3/3)", use AskUserQuestion: If the verdict is NOT "CLEARED", use AskUserQuestion:
- Show which reviews are missing or have open issues - Show that Eng Review is missing or has open issues
- RECOMMENDATION: Choose B (run missing reviews first) unless the change is trivial - RECOMMENDATION: Choose B (run eng review first) unless the change is obviously trivial (<20 lines, typo fix, config-only)
- Options: A) Ship anyway B) Abort — run missing review(s) first C) Reviews not relevant for this change - Options: A) Ship anyway B) Abort — run /plan-eng-review first C) Change is too small to need eng review
- If CEO/Design reviews are missing, mention them as informational ("CEO Review not run — recommended for product changes") but do NOT block or recommend aborting for them
--- ---

5
test/gen-skill-docs.test.ts
View File

@ -343,9 +343,10 @@ describe('REVIEW_DASHBOARD resolver', () => {
test('resolver output contains key dashboard elements', () => { test('resolver output contains key dashboard elements', () => {
const content = fs.readFileSync(path.join(ROOT, 'plan-ceo-review', 'SKILL.md'), 'utf-8'); const content = fs.readFileSync(path.join(ROOT, 'plan-ceo-review', 'SKILL.md'), 'utf-8');
expect(content).toContain('VERDICT'); expect(content).toContain('VERDICT');
expect(content).toContain('CLEARED TO SHIP'); expect(content).toContain('CLEARED');
expect(content).toContain('NOT YET RUN'); expect(content).toContain('Eng Review');
expect(content).toContain('7 days'); expect(content).toContain('7 days');
expect(content).toContain('Design Review'); expect(content).toContain('Design Review');
expect(content).toContain('skip_eng_review');
}); });
}); });