ci: least-privilege tokens on the two lanes that execute PR-controlled code

free-tests runs PR code (install lifecycle scripts + the suite) with
whatever the repo-default GITHUB_TOKEN grant is, persisted into
.git/config by checkout. Now: permissions contents:read,
persist-credentials false, pinned by the wiring test. actionlint gets
the same treatment plus a digest pin on the third-party Docker Hub
image (a tag is repointable with no GitHub-side audit trail, and the
image sees the mounted checkout). restore-keys added to both caches so
a lockfile bump warms from the previous cache; stale --parallel header
wording corrected.
This commit is contained in:
Garry Tan 2026-08-15 16:49:39 -07:00
parent fd47cd8477
commit 7b4b70babd
No known key found for this signature in database
GPG Key ID: C1F69E85C74EFE1D
3 changed files with 38 additions and 7 deletions

View File

@ -13,11 +13,20 @@ concurrency:
group: actionlint-${{ github.head_ref || github.ref_name }}
cancel-in-progress: true
# Lint needs nothing from the token; the job runs a third-party image with
# the checkout mounted, so keep the grant read-only and out of .git/config.
permissions:
contents: read
jobs:
actionlint:
runs-on: ubicloud-standard-2
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
# Pull the prebuilt image instead of rhysd/actionlint@v1.7.11 (a Docker
# action that rebuilt from source every run: 16s of a 44s job for 1s of lint).
- run: docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.11 -color
# action that rebuilt from source every run: 16s of a 44s job for 1s of
# lint). Pinned by DIGEST: a Docker Hub tag is repointable with no
# GitHub-side audit trail, and this image sees the mounted checkout.
- run: docker run --rm -v "$PWD:/repo" -w /repo rhysd/actionlint:1.7.11@sha256:6f03470d0152251d7f07f7c4dc019dbe7024c72cd952f839544c7798843efa8f -color

View File

@ -3,8 +3,9 @@ name: Free Tests
# The free suite (~400 files: test/, browse/test/, make-pdf/test/, design/test/)
# had ZERO Linux CI coverage before this lane — only a curated Windows subset
# ran anywhere. This job runs the whole thing through the canonical runner
# (scripts/test-free-shards.ts): one `bun test --parallel` invocation with
# strict-output classification, so a truncated or summary-less run can never
# (scripts/test-free-shards.ts): N concurrent shard processes (serial within
# each, plus a trailing serial tree-mutating shard) with strict-output
# classification per shard, so a truncated or summary-less run can never
# report green.
#
# Deliberately SECRETLESS: free tests make no API calls, so this lane gets no
@ -16,9 +17,9 @@ name: Free Tests
# red, fix or quarantine-with-issue — don't make it advisory; an advisory lane
# is permanent false comfort.
#
# Sizing note (decision V3): single --parallel job first. If PR runs show it
# slower than the eval matrix wall, switch to a matrix of
# `--shards N --shard i` jobs (indices are stable, empty shards no-op).
# Sizing note (decision V3): single job first. If PR runs show it slower than
# the eval matrix wall, switch to a matrix of `--shards N --shard i` jobs
# (indices are stable, empty shards no-op).
on:
pull_request:
@ -29,12 +30,20 @@ concurrency:
group: free-tests-${{ github.head_ref || github.run_id }}
cancel-in-progress: true
# Least privilege: this job executes PR-controlled code (install lifecycle
# scripts + the test suite), so the GITHUB_TOKEN gets read-only contents and
# the checkout doesn't persist it into .git/config.
permissions:
contents: read
jobs:
free-tests:
runs-on: ubicloud-standard-8
timeout-minutes: 20
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- uses: oven-sh/setup-bun@v2
with:
@ -44,6 +53,9 @@ jobs:
with:
path: ~/.bun/install/cache
key: linux-bun-${{ hashFiles('bun.lock') }}
# A lockfile bump starts from the previous cache instead of cold.
restore-keys: |
linux-bun-
- name: Install dependencies
run: bun install --frozen-lockfile
@ -52,6 +64,8 @@ jobs:
with:
path: ~/.cache/ms-playwright
key: linux-playwright-${{ hashFiles('bun.lock') }}
restore-keys: |
linux-playwright-
# Cache restores browser binaries; install is still required for system
# deps and is a fast no-op for already-present browsers.

View File

@ -53,4 +53,12 @@ describe('free-tests workflow wiring', () => {
expect(entries.length).toBe(count);
}
});
test('least-privilege token: contents read-only, credentials not persisted', () => {
// The job executes PR-controlled code (install lifecycle scripts + the
// suite itself). A default-grant GITHUB_TOKEN persisted into .git/config
// by checkout would hand that code whatever the repo default allows.
expect(source).toMatch(/permissions:\s*\n\s*contents:\s*read/);
expect(source).toMatch(/persist-credentials:\s*false/);
});
});