From 7d1b9e90f734eca7e665a9d43753dd429b09c82c Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 7 Aug 2026 15:18:11 -0700 Subject: [PATCH] fix(e2e): office-hours-spec-review turn budget fits the carved skill layout (#2473) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The test failed deterministically with error_max_turns at 9 turns on main and this branch alike (CI attempt logs + local main repro). Root cause from the failing transcript: the Spec Review Loop content is carved out of office-hours/SKILL.md into office-hours/sections/, so the agent needs discovery hops (grep SKILL.md -> ls sections/ -> read the section) before it can write — 8 tool turns + the closing text turn = 9 > the 8-turn budget, which predates the carve. Observed failures wrote a CORRECT summary on tool turn 8 and died on the closing turn. maxTurns 8 -> 12. Verified: PASS locally post-fix (7 turns this run — the extra headroom absorbs discovery-path nondeterminism). Co-Authored-By: Claude Fable 5 --- test/skill-e2e-plan.test.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/test/skill-e2e-plan.test.ts b/test/skill-e2e-plan.test.ts index 27e4d74d8..a1aac4f45 100644 --- a/test/skill-e2e-plan.test.ts +++ b/test/skill-e2e-plan.test.ts @@ -549,7 +549,13 @@ Summarize what the "Spec Review Loop" section does — specifically: Write your summary to ${ohDir}/spec-review-summary.md`, workingDirectory: ohDir, - maxTurns: 8, + // 12, not 8 (#2473): the Spec Review Loop content is CARVED out of + // SKILL.md into office-hours/sections/, so the agent legitimately needs + // discovery hops (grep SKILL.md -> ls sections/ -> read the section) + // before it can write. The 8-turn budget predates the carve — observed + // failures wrote a correct summary on tool-turn 8 and hit the cap on + // the closing text turn (error_max_turns at 9 turns, deterministic). + maxTurns: 12, timeout: 120_000, testName: 'office-hours-spec-review', runId,