From 845ae5933123c2f219b86417865759d46c580781 Mon Sep 17 00:00:00 2001
From: Greg Jackson <gregj64@gmail.com>
Date: Sat, 1 Aug 2026 18:31:24 +0100
Subject: [PATCH] fix(safety): unknown source exits 1 instead of documented 2
 (#2390)

Fixes #2390.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 bin/gstack-question-preference          |  4 ++--
 test/gstack-question-preference.test.ts | 12 ++++++++++--
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/bin/gstack-question-preference b/bin/gstack-question-preference
index eb951ebd3..cb06500d4 100755
--- a/bin/gstack-question-preference
+++ b/bin/gstack-question-preference
@@ -155,8 +155,8 @@ do_write() {
       process.exit(2);
     }
     if (!ALLOWED_SOURCES.includes(j.source)) {
-      process.stderr.write('gstack-question-preference: invalid source \"' + j.source + '\"; allowed: ' + ALLOWED_SOURCES.join(', ') + '\n');
-      process.exit(1);
+      process.stderr.write('gstack-question-preference: rejected — source \"' + j.source + '\" is not user-originated (profile poisoning defense)\n');
+      process.exit(2);
     }
 
     // Optional free_text — sanitize (no injection patterns, no newlines, <=300 chars)
diff --git a/test/gstack-question-preference.test.ts b/test/gstack-question-preference.test.ts
index 863cd9e74..99383c62d 100644
--- a/test/gstack-question-preference.test.ts
+++ b/test/gstack-question-preference.test.ts
@@ -281,8 +281,16 @@ describe('--write user-origin gate (profile-poisoning defense)', () => {
       '--write',
       JSON.stringify({ question_id: 'q1', preference: 'never-ask', source: 'anonymous' }),
     );
-    expect(r.status).not.toBe(0);
-    expect(r.stderr).toContain('invalid source');
+    expect(r.status).toBe(2);
+    expect(r.stderr).toContain('profile poisoning defense');
+  });
+
+  test('unknown source exits 2 (user-origin rejection), not 1 (validation error)', () => {
+    const r = run(
+      '--write',
+      JSON.stringify({ question_id: 'q1', preference: 'never-ask', source: 'tool-output' }),
+    );
+    expect(r.status).toBe(2);
   });
 });