From 85804bb0b5e86ec76052382ef9b6ad9d12233449 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Fri, 7 Aug 2026 15:49:23 -0700 Subject: [PATCH] fix(e2e): retro-base-branch session budget survives runner contention (#2473) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Same class as review-dashboard-via, one test over in the same file: /retro is a long multi-step flow whose clean pass measures 225-239s — a coin flip against the 240s inner budget. First CI run passed at 225s; the rerun timed out at the 240s line on all 3 attempts (exitReason "timeout"); the local verification run passed at 239s, ONE second under the old cap. Inner timeout 240s -> 360s; outer bun timeout 300s -> 480s for headroom. Verified: PASS locally post-fix (17 turns, 239s). Co-Authored-By: Claude Fable 5 --- test/skill-e2e-review.test.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/skill-e2e-review.test.ts b/test/skill-e2e-review.test.ts index b6915b57e..5eaf16ca3 100644 --- a/test/skill-e2e-review.test.ts +++ b/test/skill-e2e-review.test.ts @@ -427,7 +427,11 @@ This is a local-only repo so use the local branch (main) instead of origin/main Write your retrospective to ${dir}/retro-output.md`, workingDirectory: dir, maxTurns: 25, - timeout: 240_000, + // 360s, not 240s: same runner-contention class as review-dashboard-via. + // /retro is a long multi-step flow — a clean pass measured 225s and the + // next CI run timed out at the 240s line (exitReason "timeout", 3/3 + // attempts). Outer bun timeout below rises to 480s for headroom. + timeout: 360_000, testName: 'retro-base-branch', runId, }); @@ -444,7 +448,7 @@ Write your retrospective to ${dir}/retro-output.md`, const content = fs.readFileSync(retroPath, 'utf-8'); expect(content.length).toBeGreaterThan(100); } - }, 300_000); + }, 480_000); }); // --- Retro E2E ---