From 9dc468a6dee4d26fb43a8f0d1dfe4415ecb4b110 Mon Sep 17 00:00:00 2001 From: Garry Tan Date: Sat, 15 Aug 2026 18:39:01 -0700 Subject: [PATCH] =?UTF-8?q?test(windows):=20round-3=20curation=20=E2=80=94?= =?UTF-8?q?=20seven=20files=20the=20round-2=20wedge=20had=20been=20truncat?= =?UTF-8?q?ing?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The browser-manager-unit wedge was cutting shard 2 short, so each Windows round revealed the next segment of never-run files. With the wedge excluded, shard 2 completes (50s) and shows its real failures: seven more POSIX-environment files (PID/cmdline identity probing, bash scripts as the subject under test, env-scrubbed bun spawns). Shards 1 and 3 (including all tree-mutators) now PASS on windows-latest — this should be the fixed point: ~234 files of real Windows coverage vs the 13 hand-picked before. --- scripts/test-free-shards.ts | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/scripts/test-free-shards.ts b/scripts/test-free-shards.ts index c8491f0c4..f40219ded 100755 --- a/scripts/test-free-shards.ts +++ b/scripts/test-free-shards.ts @@ -206,6 +206,38 @@ export const KNOWN_WINDOWS_INCOMPATIBLE: Array<{ file: string; reason: string }> file: 'browse/test/browser-manager-unit.test.ts', reason: 'wedges the shard to its wall deadline on windows-latest (in-flight at kill); needs a Windows repro to diagnose — macOS + Linux lanes cover the file', }, + // Round-3 census (PR #2593 run 31919871680): the round-2 wedge had been + // TRUNCATING its shard, so these seven only surfaced once shard 2 completed. + // All the same POSIX-environment classes: PID/cmdline identity probing, + // bash scripts as the subject under test, env-scrubbed child spawns. + { + file: 'browse/test/server-embedder-terminal-port.test.ts', + reason: 'identity-based terminal-agent kill probes PID/cmdline with POSIX semantics; teardown asserts fail on windows-latest', + }, + { + file: 'design/test/daemon-discovery.test.ts', + reason: 'verifyIdentity matches a spawned daemon via /proc-style cmdline probing — POSIX identity semantics', + }, + { + file: 'test/context-save-hardening.test.ts', + reason: 'bash context-save/migration scripts (HOME-unset semantics, random-suffix path) are the subject under test', + }, + { + file: 'test/eval-list-cli.test.ts', + reason: 'spawns the eval:list CLI via bun with a constructed env — bun resolution fails under Windows spawn', + }, + { + file: 'test/memory-cache-injection.test.ts', + reason: 'exercises hook/deny-enforcement shell scripts — POSIX toolchain is the subject under test', + }, + { + file: 'test/migrations-v1.65.0.0.test.ts', + reason: 'bash migration script (bunx re-fetch, .done markers) is the subject under test', + }, + { + file: 'test/question-preference-hook.test.ts', + reason: 'spawns the PreToolUse preference hook (shebang script) directly; Windows spawn cannot exec it', + }, ]; // Force-include overrides: files a WINDOWS_FRAGILE_PATTERNS regex excludes for