RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test(preamble): assert update_check gates echo + upgrade prose 

Iterates every generated SKILL.md carrying the runtime config-echo
cluster and asserts it echoes UPDATE_CHECK, reads the update_check
config, and gates the UPGRADE_AVAILABLE / JUST_UPGRADED prose on the
flag. Guards against the scope filter matching nothing. Pins the #2001
fix so the instruction layer can't silently drift back to ignoring the
opt-out.

Refs #2001.
This commit is contained in:
0xDevNinja 2026-06-16 12:28:06 +05:30
parent 257e9e3ef5
commit a53892b4c4
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
test/gen-skill-docs.test.ts
View File

@ -323,6 +323,31 @@ describe('gen-skill-docs', () => {
expect(content).toContain('git branch --show-current');
});
// #2001: update_check: false silences the binary but the upgrade-handling
// instruction prose used to ship unconditionally. Every skill that carries
// the runtime config-echo cluster must (a) echo UPDATE_CHECK so the
// instruction layer can read it, and (b) gate the UPGRADE_AVAILABLE /
// JUST_UPGRADED prose on it — the same echo-then-gate convention every other
// flag (PROACTIVE, SKILL_PREFIX, EXPLAIN_LEVEL, QUESTION_TUNING) follows.
test('update_check opt-out gates preamble echo and upgrade-handling prose (issue #2001)', () => {
let checked = 0;
for (const skill of CLAUDE_GENERATED_SKILLS) {
const content = fs.readFileSync(path.join(ROOT, skill.dir, 'SKILL.md'), 'utf-8');
// Scope: only skills that render the runtime config-echo cluster.
if (!content.includes('echo "QUESTION_TUNING: $_QUESTION_TUNING"')) continue;
checked++;
expect(content, `${skill.dir} must echo UPDATE_CHECK`).toContain('echo "UPDATE_CHECK: $_UPDATE_CHECK"');
expect(content, `${skill.dir} must read update_check config`).toContain('_UPDATE_CHECK=$(');
// Whenever the upgrade-handling prose ships, it must gate on the flag.
if (content.includes('UPGRADE_AVAILABLE <old> <new>')) {
expect(content, `${skill.dir} upgrade prose must gate on UPDATE_CHECK`)
.toContain('If `UPDATE_CHECK` is `"false"`');
}
}
// Guard against the scope filter silently matching nothing.
expect(checked).toBeGreaterThan(0);
});
test('tier 2+ skills contain ELI10 simplification rules (AskUserQuestion format)', () => {
// Root SKILL.md is tier 1 (no AskUserQuestion format). Check a tier 2+ skill instead.
// v1.7.0.0 Pros/Cons format uses "ELI10 (ALWAYS)" rather than "Simplify (ELI10".