RomanNum3ral
/
gstack
mirror of https://github.com/garrytan/gstack.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: suppress fake "session ended" and timeout errors in sidebar 

Two issues making the sidebar look broken when it's actually working:
1. "Timed out after 300s" error displayed after agent_done — this is a
   cleanup timer, not a real error. Now suppressed when no active session.
2. "(session ended)" text appended on every idle poll — removed entirely.
   The thinking spinner is cleaned up silently instead.
This commit is contained in:
Garry Tan 2026-04-02 19:18:26 -07:00
parent 16885537c2
commit b4deb0b81e
No known key found for this signature in database
GPG Key ID: C1F69E85C74EFE1D
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
extension/sidepanel.js
View File

@ -209,6 +209,10 @@ function handleAgentEvent(entry) {
} }
if (entry.type === 'agent_error') { if (entry.type === 'agent_error') {
// Suppress timeout errors that fire after agent_done (cleanup noise)
if (entry.error && entry.error.includes('Timed out') && !agentContainer) {
return;
}
const thinking = document.getElementById('agent-thinking'); const thinking = document.getElementById('agent-thinking');
if (thinking) thinking.remove(); if (thinking) thinking.remove();
updateStopButton(false); updateStopButton(false);
@ -402,20 +406,14 @@ async function pollChat() {
} }
// Clean up orphaned thinking indicators after replay. // Clean up orphaned thinking indicators after replay.
// Only show "(session ended)" if there's actually a thinking spinner
// to clean up (not on every idle poll, which would spam the chat).
const thinking = document.getElementById('agent-thinking'); const thinking = document.getElementById('agent-thinking');
if (thinking && data.agentStatus !== 'processing') { if (thinking && data.agentStatus !== 'processing') {
thinking.remove(); thinking.remove();
if (agentContainer) {
const notice = document.createElement('div');
notice.className = 'agent-text';
notice.style.color = 'var(--text-meta)';
notice.style.fontStyle = 'italic';
notice.textContent = '(session ended)';
agentContainer.appendChild(notice);
agentContainer = null; agentContainer = null;
agentTextEl = null; agentTextEl = null;
} }
}
// Show/hide stop button based on agent status // Show/hide stop button based on agent status
updateStopButton(data.agentStatus === 'processing'); updateStopButton(data.agentStatus === 'processing');